Bug 1518094 - Fix test_*_autocomplete.html autofill failures by setting prefs sooner. r=jaws

Move prefs from pwmgr_common.js to mochitest.ini and remove redundant calls to set those same prefs.

Differential Revision: https://phabricator.services.mozilla.com/D17589

--HG--
extra : moz-landing-system : lando

toolkit/components/passwordmgr/test/mochitest.ini

@@ -1,4 +1,9 @@
 [DEFAULT]
+prefs =
+  signon.rememberSignons=true
+  signon.autofillForms.http=true
+  security.insecure_field_warning.contextual.enabled=false
+  network.auth.non-web-content-triggered-resources-http-auth-allow=true
 skip-if = e10s
 support-files =
   authenticate.sjs

toolkit/components/passwordmgr/test/mochitest/mochitest.ini

@@ -1,4 +1,10 @@
 [DEFAULT]
+prefs =
+  signon.rememberSignons=true
+  signon.autofillForms.http=true
+  security.insecure_field_warning.contextual.enabled=false
+  network.auth.non-web-content-triggered-resources-http-auth-allow=true
+
 support-files =
   ../../../prompts/test/chromeScript.js
   ../../../prompts/test/prompt_common.js

toolkit/components/passwordmgr/test/mochitest/test_basic_form_autocomplete.html

@@ -209,8 +209,6 @@ function spinEventLoop() {
 }
 
 add_task(async function setup() {
-  await SpecialPowers.pushPrefEnv({"set": [["security.insecure_field_warning.contextual.enabled", false],
-                                           ["signon.autofillForms.http", true]]});
   listenForUnexpectedPopupShown();
 });
 

toolkit/components/passwordmgr/test/mochitest/test_insecure_form_field_autocomplete.html

@@ -209,8 +209,7 @@ function spinEventLoop() {
 }
 
 add_task(async function setup() {
-  await SpecialPowers.pushPrefEnv({"set": [["security.insecure_field_warning.contextual.enabled", true],
+  await SpecialPowers.pushPrefEnv({"set": [["security.insecure_field_warning.contextual.enabled", true]]});
-                                           ["signon.autofillForms.http", true]]});
   listenForUnexpectedPopupShown();
 });
 

toolkit/components/passwordmgr/test/mochitest/test_username_focus.html

@@ -114,10 +114,6 @@ function removeFocus() {
 }
 
 add_task(async function setup() {
-  await SpecialPowers.pushPrefEnv({"set": [
-    ["security.insecure_field_warning.contextual.enabled", false],
-  ]});
-
   ok(readyPromise, "check promise is available");
   await readyPromise;
 });

toolkit/components/passwordmgr/test/pwmgr_common.js

@@ -447,11 +447,6 @@ if (this.addMessageListener) {
   });
 } else {
   // Code to only run in the mochitest pages (not in the chrome script).
-  SpecialPowers.pushPrefEnv({"set": [["signon.rememberSignons", true],
-                                     ["signon.autofillForms.http", true],
-                                     ["security.insecure_field_warning.contextual.enabled", false],
-                                     ["network.auth.non-web-content-triggered-resources-http-auth-allow", true]],
-  });
   SimpleTest.registerCleanupFunction(() => {
     SpecialPowers.popPrefEnv();
     runInParent(function cleanupParent() {