Bug 1446533 part 5. Remove nsIDOMCharacterData::AppendData. r=mystor

MozReview-Commit-ID: JP809oJeQiX

dom/base/CharacterData.cpp

@@ -221,11 +221,14 @@ CharacterData::SubstringData(uint32_t aStart, uint32_t aCount,
 
 //----------------------------------------------------------------------
 
-nsresult
-CharacterData::AppendData(const nsAString& aData)
+void
+CharacterData::AppendData(const nsAString& aData, ErrorResult& aRv)
 {
-  return SetTextInternal(mText.GetLength(), 0, aData.BeginReading(),
+  nsresult rv = SetTextInternal(mText.GetLength(), 0, aData.BeginReading(),
                                 aData.Length(), true);
+  if (NS_FAILED(rv)) {
+    aRv.Throw(rv);
+  }
 }
 
 nsresult

dom/base/CharacterData.h

@@ -97,7 +97,6 @@ public:
 
   // Implementation for nsIDOMCharacterData
   nsresult GetLength(uint32_t* aLength);
-  nsresult AppendData(const nsAString& aArg);
   nsresult InsertData(uint32_t aOffset, const nsAString& aArg);
   nsresult DeleteData(uint32_t aOffset, uint32_t aCount);
   nsresult ReplaceData(uint32_t aOffset, uint32_t aCount,
@@ -184,10 +183,7 @@ public:
   // nsINode::Length() returns the right thing for our length attribute
   void SubstringData(uint32_t aStart, uint32_t aCount, nsAString& aReturn,
                      ErrorResult& rv);
-  void AppendData(const nsAString& aData, ErrorResult& rv)
-  {
-    rv = AppendData(aData);
-  }
+  void AppendData(const nsAString& aData, ErrorResult& rv);
   void InsertData(uint32_t aOffset, const nsAString& aData, ErrorResult& rv)
   {
     rv = InsertData(aOffset, aData);

dom/interfaces/core/nsIDOMCharacterData.idl

@@ -17,8 +17,6 @@
 interface nsIDOMCharacterData : nsIDOMNode
 {
   readonly attribute unsigned long        length;
-  void                      appendData(in DOMString arg)
-                                  raises(DOMException);
   void                      insertData(in unsigned long offset, 
                                        in DOMString arg)
                                   raises(DOMException);