Bug 1516015 - Fix proxy configuration for Raptor in Google Chrome; r=rwood

When investigating the timeouts for wikia.com on Google Chrome I discovered differences in the way proxy configuration is interpreted. It meant that insecure sites such as wikia were not using the proxy when launched via mach, and now that wikia.com redirects to a secure site we get redirected to a site that is not in the recordings. I have resolved this by fixing the command line argument for the proxy to include all protocols. It was also necesary to allow communication with the control server by adding localhost to the pass-through hosts.

I also removed the trailing disable-sync command line argument that was introduced recently in error.

Differential Revision: https://phabricator.services.mozilla.com/D17869

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Dave Hunt 2019-01-28 22:12:00 +00:00
Родитель 12e0f305f3
Коммит bff88648b3
1 изменённых файлов: 2 добавлений и 3 удалений

Просмотреть файл

@ -362,11 +362,10 @@ class Raptor(object):
# if using host localhost, 127.0.0.1.
if self.config['app'] == "chrome" and test.get('playback', None) is not None:
chrome_args = [
'--proxy-server="http=127.0.0.1:8080;' +
'https=127.0.0.1:8080;ssl=127.0.0.1:8080"',
'--proxy-server=127.0.0.1:8080',
'--proxy-bypass-list=localhost;127.0.0.1',
'--ignore-certificate-errors',
'--no-default-browser-check',
'disable-sync'
]
if self.config['host'] not in ('localhost', '127.0.0.1'):
chrome_args[0] = chrome_args[0].replace('127.0.0.1', self.config['host'])