Bug 1918226 - Use Glean APIs for avif.dav1d_get_picture#return_value r=tnikkel

Differential Revision: https://phabricator.services.mozilla.com/D221494

image/decoders/metrics.yaml

@@ -438,3 +438,25 @@ avif:
     notification_emails:
       - media-alerts@mozilla.com
     expires: never
+
+  dav1d_get_picture_return_value:
+    type: event
+    description: >
+      Return value from dav1d_get_picture
+      This event was generated to correspond to the Legacy Telemetry event
+      avif.dav1d_get_picture#return_value.
+    bugs:
+      - https://bugzil.la/1690406
+    data_reviews:
+      - https://bugzil.la/1690406
+    notification_emails:
+      - media-alerts@mozilla.com
+    expires: never
+    extra_keys:
+      value:
+        description: >
+          The `value` of the event. Mirrors to the Legacy Telemetry
+          event's `value` parameter.
+          The `Dav1dResult` returned from `dav1d_get_picture(...)`.
+        type: string
+    telemetry_mirror: Avif_Dav1dGetPicture_ReturnValue

image/decoders/nsAVIFDecoder.cpp

@@ -19,7 +19,6 @@
 
 #include "mozilla/glean/GleanMetrics.h"
 #include "mozilla/Telemetry.h"
-#include "mozilla/TelemetryComms.h"
 #include "mozilla/UniquePtrExtensions.h"
 
 using namespace mozilla::gfx;
@@ -677,9 +676,10 @@ class Dav1dDecoder final : AVIFDecoderInterface {
       // Uncomment once bug 1691156 is fixed
       // mozilla::Telemetry::SetEventRecordingEnabled("avif"_ns, true);
 
-      mozilla::Telemetry::RecordEvent(
-          mozilla::Telemetry::EventID::Avif_Dav1dGetPicture_ReturnValue,
-          Some(nsPrintfCString("%d", r)), Nothing());
+      mozilla::glean::avif::Dav1dGetPictureReturnValueExtra extra = {
+          .value = Some(nsPrintfCString("%d", r)),
+      };
+      mozilla::glean::avif::dav1d_get_picture_return_value.Record(Some(extra));
     }
 
     return r;