From c0393ce78fee74caf97ae10ae539c498b33c0613 Mon Sep 17 00:00:00 2001 From: Ralph Giles Date: Wed, 11 May 2016 17:18:07 -0700 Subject: [PATCH] Bug 1267887 - Document MP4AudioInfo::IsValid(). r=jya Jean-Yves and I both found this logic confusing. MozReview-Commit-ID: C5phemRPDQZ --- media/libstagefright/binding/DecoderData.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/media/libstagefright/binding/DecoderData.cpp b/media/libstagefright/binding/DecoderData.cpp index c21cfa67b8a8..505f20828e9a 100644 --- a/media/libstagefright/binding/DecoderData.cpp +++ b/media/libstagefright/binding/DecoderData.cpp @@ -156,6 +156,7 @@ bool MP4AudioInfo::IsValid() const { return mChannels > 0 && mRate > 0 && + // Accept any mime type here, but if it's aac, validate the profile. (!mMimeType.Equals(MEDIA_MIMETYPE_AUDIO_AAC) || mProfile > 0 || mExtendedProfile > 0); }