Bug 1018680 - Fix jsd_xpc.cpp warning and mark js/ductwork, js/jsd, and js/xpconnet as FAIL_ON_WARNINGS. r=ejpbruel

js/ductwork/debugger/moz.build

@@ -21,3 +21,5 @@ EXTRA_JS_MODULES += [
 ]
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True

js/jsd/jsd_xpc.cpp

@@ -1681,7 +1681,7 @@ jsdContext::SetOptions(uint32_t options)
     /* don't let users change this option, they'd just be shooting themselves
      * in the foot. */
     if (JS::ContextOptionsRef(mJSCx).privateIsNSISupports() !=
-        (options & JSOPTION_PRIVATE_IS_NSISUPPORTS))
+        !!(options & JSOPTION_PRIVATE_IS_NSISUPPORTS))
         return NS_ERROR_ILLEGAL_VALUE;
 
     JS::ContextOptionsRef(mJSCx).setExtraWarnings(options & JSOPTION_EXTRA_WARNINGS)

js/jsd/moz.build

@@ -35,3 +35,5 @@ if CONFIG['JS_THREADSAFE']:
     DEFINES['JS_THREADSAFE'] = True
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True

js/xpconnect/tests/components/native/moz.build

@@ -23,3 +23,5 @@ DEFINES['LIBRARY_FILENAME'] = '%s%s%s' % (
     LIBRARY_NAME,
     CONFIG['DLL_SUFFIX']
 )
+
+FAIL_ON_WARNINGS = True

js/xpconnect/wrappers/moz.build

@@ -22,7 +22,12 @@ SOURCES += [
 ]
 
 # warning C4661 for FilteringWrapper
-FAIL_ON_WARNINGS = not CONFIG['_MSC_VER']
+if CONFIG['_MSC_VER']:
+    CXXFLAGS += [
+        '-wd4661', # no suitable definition provided for explicit template instantiation request
+    ]
+
+FAIL_ON_WARNINGS = True
 
 MSVC_ENABLE_PGO = True