mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1571092 - Mark various MozPromise-returning methods MOZ_MUST_USE. r=jld 

Differential Revision: https://phabricator.services.mozilla.com/D40528

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Bobby Holley 2019-08-05 20:10:58 +00:00
Родитель 44eb662657
Коммит c14858c637
1 изменённых файлов: 9 добавлений и 8 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

17
xpcom/threads/MozPromise.h
Просмотреть файл

@ -246,8 +246,8 @@ class MozPromise : public MozPromiseBase {
class Private; class Private;
template <typename ResolveValueType_> template <typename ResolveValueType_>
static RefPtr<MozPromise> CreateAndResolve(ResolveValueType_&& aResolveValue, static MOZ_MUST_USE RefPtr<MozPromise> CreateAndResolve(
const char* aResolveSite) { ResolveValueType_&& aResolveValue, const char* aResolveSite) {
static_assert(IsConvertible<ResolveValueType_, ResolveValueT>::value, static_assert(IsConvertible<ResolveValueType_, ResolveValueT>::value,
"Resolve() argument must be implicitly convertible to " "Resolve() argument must be implicitly convertible to "
"MozPromise's ResolveValueT"); "MozPromise's ResolveValueT");
@ -258,8 +258,8 @@ class MozPromise : public MozPromiseBase {
} }
template <typename RejectValueType_> template <typename RejectValueType_>
static RefPtr<MozPromise> CreateAndReject(RejectValueType_&& aRejectValue, static MOZ_MUST_USE RefPtr<MozPromise> CreateAndReject(
const char* aRejectSite) { RejectValueType_&& aRejectValue, const char* aRejectSite) {
static_assert(IsConvertible<RejectValueType_, RejectValueT>::value, static_assert(IsConvertible<RejectValueType_, RejectValueT>::value,
"Reject() argument must be implicitly convertible to " "Reject() argument must be implicitly convertible to "
"MozPromise's RejectValueT"); "MozPromise's RejectValueT");
@ -270,7 +270,7 @@ class MozPromise : public MozPromiseBase {
} }
template <typename ResolveOrRejectValueType_> template <typename ResolveOrRejectValueType_>
static RefPtr<MozPromise> CreateAndResolveOrReject( static MOZ_MUST_USE RefPtr<MozPromise> CreateAndResolveOrReject(
ResolveOrRejectValueType_&& aValue, const char* aSite) { ResolveOrRejectValueType_&& aValue, const char* aSite) {
RefPtr<typename MozPromise::Private> p = new MozPromise::Private(aSite); RefPtr<typename MozPromise::Private> p = new MozPromise::Private(aSite);
p->ResolveOrReject(std::forward<ResolveOrRejectValueType_>(aValue), aSite); p->ResolveOrReject(std::forward<ResolveOrRejectValueType_>(aValue), aSite);
@ -330,8 +330,9 @@ class MozPromise : public MozPromiseBase {
}; };
public: public:
static RefPtr<AllPromiseType> All(nsISerialEventTarget* aProcessingTarget, static MOZ_MUST_USE RefPtr<AllPromiseType> All(
nsTArray<RefPtr<MozPromise>>& aPromises) { nsISerialEventTarget* aProcessingTarget,
nsTArray<RefPtr<MozPromise>>& aPromises) {
if (aPromises.Length() == 0) { if (aPromises.Length() == 0) {
return AllPromiseType::CreateAndResolve(nsTArray<ResolveValueType>(), return AllPromiseType::CreateAndResolve(nsTArray<ResolveValueType>(),
__func__); __func__);
@ -940,7 +941,7 @@ class MozPromise : public MozPromiseBase {
# ifdef MOZ_WIDGET_ANDROID # ifdef MOZ_WIDGET_ANDROID
// Creates a C++ MozPromise from its Java counterpart, GeckoResult. // Creates a C++ MozPromise from its Java counterpart, GeckoResult.
static RefPtr<MozPromise> FromGeckoResult( static MOZ_MUST_USE RefPtr<MozPromise> FromGeckoResult(
java::GeckoResult::Param aGeckoResult) { java::GeckoResult::Param aGeckoResult) {
using jni::GeckoResultCallback; using jni::GeckoResultCallback;
RefPtr<Private> p = new Private("GeckoResult Glue", false); RefPtr<Private> p = new Private("GeckoResult Glue", false);