Bug 1583251 - P2 - Fix some format nits or naming nits for StructuredClone::Write; r=nika,lth

Differential Revision: https://phabricator.services.mozilla.com/D48348

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Tom Tung 2019-10-15 13:49:26 +00:00
Родитель 3f6f9df494
Коммит c291baa433
3 изменённых файлов: 8 добавлений и 8 удалений

Просмотреть файл

@ -172,14 +172,14 @@ bool StructuredCloneHolderBase::Write(JSContext* aCx,
bool StructuredCloneHolderBase::Write(JSContext* aCx,
JS::Handle<JS::Value> aValue,
JS::Handle<JS::Value> aTransfer,
JS::CloneDataPolicy cloneDataPolicy) {
JS::CloneDataPolicy aCloneDataPolicy) {
MOZ_ASSERT(!mBuffer, "Double Write is not allowed");
MOZ_ASSERT(!mClearCalled, "This method cannot be called after Clear.");
mBuffer = MakeUnique<JSAutoStructuredCloneBuffer>(
mStructuredCloneScope, &StructuredCloneHolder::sCallbacks, this);
if (!mBuffer->write(aCx, aValue, aTransfer, cloneDataPolicy,
if (!mBuffer->write(aCx, aValue, aTransfer, aCloneDataPolicy,
&StructuredCloneHolder::sCallbacks, this)) {
mBuffer = nullptr;
return false;
@ -353,10 +353,10 @@ JSObject* StructuredCloneHolder::ReadFullySerializableObjects(
// the casting between JSPrincipals* and nsIPrincipal* we can't use
// getter_AddRefs above and have to already_AddRefed here.
nsCOMPtr<nsIPrincipal> principal =
already_AddRefed<nsIPrincipal>(nsJSPrincipals::get(prin));
already_AddRefed<nsIPrincipal>(nsJSPrincipals::get(prin));
nsresult rv = nsContentUtils::WrapNative(
aCx, principal, &NS_GET_IID(nsIPrincipal), &result);
aCx, principal, &NS_GET_IID(nsIPrincipal), &result);
if (NS_FAILED(rv)) {
xpc::Throw(aCx, NS_ERROR_DOM_DATA_CLONE_ERR);
return nullptr;
@ -838,7 +838,7 @@ JSObject* ReadInputStream(JSContext* aCx, uint32_t aIndex,
nsCOMPtr<nsIInputStream> inputStream = aHolder->InputStreams()[aIndex];
nsresult rv = nsContentUtils::WrapNative(
aCx, inputStream, &NS_GET_IID(nsIInputStream), &result);
aCx, inputStream, &NS_GET_IID(nsIInputStream), &result);
if (NS_FAILED(rv)) {
return nullptr;
}

Просмотреть файл

@ -98,7 +98,7 @@ class StructuredCloneHolderBase {
// of cloning policy.
bool Write(JSContext* aCx, JS::Handle<JS::Value> aValue,
JS::Handle<JS::Value> aTransfer,
JS::CloneDataPolicy cloneDataPolicy);
JS::CloneDataPolicy aCloneDataPolicy);
// If Write() has been called, this method retrieves data and stores it into
// aValue.
@ -160,7 +160,7 @@ class StructuredCloneHolder : public StructuredCloneHolderBase {
void Write(JSContext* aCx, JS::Handle<JS::Value> aValue,
JS::Handle<JS::Value> aTransfer,
JS::CloneDataPolicy cloneDataPolicy, ErrorResult& aRv);
JS::CloneDataPolicy aCloneDataPolicy, ErrorResult& aRv);
void Read(nsISupports* aParent, JSContext* aCx,
JS::MutableHandle<JS::Value> aValue, ErrorResult& aRv);

Просмотреть файл

@ -208,7 +208,7 @@ class CloneDataPolicy {
bool sharedArrayBuffer_;
public:
// The default is to allow all policy-controlled aspects.
// The default is to deny all policy-controlled aspects.
CloneDataPolicy() : sharedArrayBuffer_(false) {}