Bug 896980 - Add error handlings if fail to init track encoder or container writer. r=roc

content/media/encoder/TrackEncoder.cpp

@@ -27,6 +27,10 @@ AudioTrackEncoder::NotifyQueuedTrackChanges(MediaStreamGraph* aGraph,
                                             uint32_t aTrackEvents,
                                             const MediaSegment& aQueuedMedia)
 {
+  if (mCanceled) {
+    return;
+  }
+
   AudioSegment* audio = const_cast<AudioSegment*>
                         (static_cast<const AudioSegment*>(&aQueuedMedia));
 
@@ -40,9 +44,11 @@ AudioTrackEncoder::NotifyQueuedTrackChanges(MediaStreamGraph* aGraph,
       // thus the audio encoder is initialized at this time.
       if (!chunk.IsNull()) {
         nsresult rv = Init(chunk.mChannelData.Length(), aTrackRate);
-        if (NS_SUCCEEDED(rv)) {
-          break;
+        if (NS_FAILED(rv)) {
+          LOG("[AudioTrackEncoder]: Fail to initialize the encoder!");
+          NotifyCancel();
         }
+        break;
       } else {
         mSilentDuration += chunk.mDuration;
       }

content/media/ogg/OggWriter.cpp

@@ -49,6 +49,11 @@ nsresult
 OggWriter::WriteEncodedTrack(const nsTArray<uint8_t>& aBuffer, int aDuration,
                              uint32_t aFlags)
 {
+  if (!mInitialized) {
+    LOG("[OggWriter] OggWriter has not initialized!");
+    return NS_ERROR_FAILURE;
+  }
+
   MOZ_ASSERT(!ogg_stream_eos(&mOggStreamState),
              "No data can be written after eos has marked.");