Backed out changeset f057b78337e7 (bug 1544436) for debugger failures on addToTree.js CLOSED TREE

devtools/client/debugger/src/actions/pause/paused.js

@@ -7,6 +7,7 @@ import {
   getHiddenBreakpoint,
   isEvaluatingExpression,
   getSelectedFrame,
+  wasStepping,
   getThreadContext
 } from "../../selectors";
 
@@ -14,6 +15,7 @@ import { mapFrames } from ".";
 import { removeBreakpoint } from "../breakpoints";
 import { evaluateExpressions } from "../expressions";
 import { selectLocation } from "../sources";
+import { togglePaneCollapse } from "../ui";
 import assert from "../../utils/assert";
 
 import { fetchScopes } from "./fetchScopes";
@@ -58,6 +60,10 @@ export function paused(pauseInfo: Pause) {
       await dispatch(selectLocation(cx, selectedFrame.location));
     }
 
+    if (!wasStepping(getState(), thread)) {
+      dispatch(togglePaneCollapse("end", false));
+    }
+
     await dispatch(fetchScopes(cx));
 
     // Run after fetching scoping data so that it may make use of the sourcemap

devtools/client/debugger/src/utils/sources-tree/addToTree.js

@@ -157,7 +157,8 @@ function addSourceToNode(
 export function addToTree(
   tree: TreeDirectory,
   source: Source,
-  debuggeeHost: ?string
+  debuggeeHost: ?string,
+  projectRoot: string
 ) {
   const url = getURL(source, debuggeeHost);
 

devtools/client/debugger/src/utils/sources-tree/createTree.js

@@ -14,16 +14,17 @@ import type { TreeDirectory } from "./types";
 
 type Params = {
   sources: SourcesMap,
-  debuggeeUrl: string
+  debuggeeUrl: string,
+  projectRoot: string
 };
 
-export function createTree({ sources, debuggeeUrl }: Params) {
+export function createTree({ sources, debuggeeUrl, projectRoot }: Params) {
   const uncollapsedTree = createDirectoryNode("root", "", []);
   const debuggeeHost = getDomain(debuggeeUrl);
 
   for (const sourceId in sources) {
     const source = sources[sourceId];
-    addToTree(uncollapsedTree, source, debuggeeHost);
+    addToTree(uncollapsedTree, source, debuggeeHost, projectRoot);
   }
 
   const sourceTree = collapseTree((uncollapsedTree: TreeDirectory));

devtools/client/debugger/src/utils/sources-tree/tests/addToTree.spec.js

@@ -106,7 +106,6 @@ describe("sources-tree", () => {
       const tree = createDirectoryNode("root", "", []);
 
       addToTree(tree, source1, "http://example.com/", "");
-      console.log(formatTree(tree));
       expect(formatTree(tree)).toMatchSnapshot();
     });
 

devtools/client/debugger/src/utils/sources-tree/updateTree.js

@@ -34,6 +34,7 @@ export function updateTree({
   newSources,
   prevSources,
   debuggeeUrl,
+  projectRoot,
   uncollapsedTree,
   sourceTree
 }: Params) {
@@ -41,7 +42,7 @@ export function updateTree({
   const debuggeeHost = getDomain(debuggeeUrl);
 
   for (const source of newSet) {
-    addToTree(uncollapsedTree, source, debuggeeHost);
+    addToTree(uncollapsedTree, source, debuggeeHost, projectRoot);
   }
 
   const newSourceTree = collapseTree(uncollapsedTree);