Bug 1529300 - Remove support for legacy {ELEMENT: <UUID>} web element objects. r=ato

Differential Revision: https://phabricator.services.mozilla.com/D21667

--HG--
extra : moz-landing-system : lando

testing/geckodriver/CHANGES.md

@@ -9,6 +9,15 @@ Unreleased
 
 ### Removed
 
+- Dropped support for legacy Selenium web element references
+
+  The legacy way of serialising web elements, using `{"ELEMENT": <UUID>}`,
+  has been removed in this release.  This may break older Selenium
+  clients and clients which are otherwise not compatible with the
+  WebDriver standard.
+
+  Thanks to Shivam Singhal for this patch.
+
 - Removed `--webdriver-port` command-line option
 
   `--webdriver-port <PORT>` was an undocumented alias for `--port`,

testing/geckodriver/src/command.rs

@@ -14,7 +14,6 @@ use webdriver::error::{ErrorStatus, WebDriverError, WebDriverResult};
 use webdriver::httpapi::WebDriverExtensionRoute;
 
 pub const CHROME_ELEMENT_KEY: &'static str = "chromeelement-9fc5-4b51-a3c8-01716eedeb04";
-pub const LEGACY_ELEMENT_KEY: &'static str = "ELEMENT";
 
 pub fn extension_routes() -> Vec<(Method, &'static str, GeckoExtensionRoute)> {
     return vec![

testing/geckodriver/src/marionette.rs

@@ -1,7 +1,6 @@
 use crate::command::{
     AddonInstallParameters, AddonUninstallParameters, GeckoContextParameters,
     GeckoExtensionCommand, GeckoExtensionRoute, XblLocatorParameters, CHROME_ELEMENT_KEY,
-    LEGACY_ELEMENT_KEY,
 };
 use mozprofile::preferences::Pref;
 use mozprofile::profile::Profile;
@@ -393,12 +392,10 @@ impl MarionetteSession {
         let chrome_element = data.get(CHROME_ELEMENT_KEY);
         let element = data.get(ELEMENT_KEY);
         let frame = data.get(FRAME_KEY);
-        let legacy_element = data.get(LEGACY_ELEMENT_KEY);
         let window = data.get(WINDOW_KEY);
 
         let value = try_opt!(
             element
-                .or(legacy_element)
                 .or(chrome_element)
                 .or(frame)
                 .or(window),

testing/webdriver/src/actions.rs

@@ -929,7 +929,6 @@ mod test {
             "type":"pointerMove",
             "duration":100,
             "origin":{
-                "ELEMENT":"elem",
                 "element-6066-11e4-a52e-4f735466cecf":"elem"
             },
             "x":5,
@@ -951,7 +950,7 @@ mod test {
             "type":"pointerMove",
             "duration":100,
             "origin":{
-                "ELEMENT":"elem"
+                "element-6066-11e4-a52e-4f735466cecf":"elem"
             },
             "x":5,
             "y":10