зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1663128 - part1 : remove unused function 'SetControlledTabBrowsingContextId()'. r=chunmin
As we've chosen another way for GeckoView implementation, so `SetControlledTabBrowsingContextId` is no longer needed. Differential Revision: https://phabricator.services.mozilla.com/D92114
This commit is contained in:
Родитель
ee1c7a7da4
Коммит
c4860628a6
|
@ -164,18 +164,6 @@ void MediaControlKeyManager::SetSupportedMediaKeys(
|
|||
}
|
||||
}
|
||||
|
||||
void MediaControlKeyManager::SetControlledTabBrowsingContextId(
|
||||
Maybe<uint64_t> aTopLevelBrowsingContextId) {
|
||||
if (aTopLevelBrowsingContextId) {
|
||||
LOG_INFO("Controlled tab Id=%" PRId64, *aTopLevelBrowsingContextId);
|
||||
} else {
|
||||
LOG_INFO("No controlled tab exists");
|
||||
}
|
||||
if (mEventSource && mEventSource->IsOpened()) {
|
||||
mEventSource->SetControlledTabBrowsingContextId(aTopLevelBrowsingContextId);
|
||||
}
|
||||
}
|
||||
|
||||
void MediaControlKeyManager::SetEnableFullScreen(bool aIsEnabled) {
|
||||
LOG_INFO("Set fullscreen %s", aIsEnabled ? "enabled" : "disabled");
|
||||
if (mEventSource && mEventSource->IsOpened()) {
|
||||
|
|
|
@ -31,9 +31,6 @@ class MediaControlKeyManager final : public MediaControlKeySource,
|
|||
bool Open() override;
|
||||
bool IsOpened() const override;
|
||||
|
||||
void SetControlledTabBrowsingContextId(
|
||||
Maybe<uint64_t> aTopLevelBrowsingContextId) override;
|
||||
|
||||
void SetPlaybackState(MediaSessionPlaybackState aState) override;
|
||||
MediaSessionPlaybackState GetPlaybackState() const override;
|
||||
|
||||
|
|
|
@ -95,17 +95,6 @@ class MediaControlKeySource {
|
|||
* the same time, we would only update information from one of that tabs that
|
||||
* would be done by `MediaControlService`.
|
||||
*/
|
||||
|
||||
// Currently, this method is only useful for GeckoView. It would be called
|
||||
// before all the other `SetXXX()` functions after the key source is open.
|
||||
// It's used to indicate where the property change occurs. We would send the
|
||||
// top level browsing context Id in order to allow the key source know which
|
||||
// tab that the following coming information belong to. This function would be
|
||||
// called whenever we change the controlled tab. If no controlled tab exists,
|
||||
// the `aTopLevelBrowsingContextId` would be `Nothing()`.
|
||||
virtual void SetControlledTabBrowsingContextId(
|
||||
Maybe<uint64_t> aTopLevelBrowsingContextId){};
|
||||
|
||||
virtual void SetPlaybackState(MediaSessionPlaybackState aState);
|
||||
virtual MediaSessionPlaybackState GetPlaybackState() const;
|
||||
|
||||
|
|
|
@ -407,7 +407,6 @@ void MediaControlService::ControllerManager::UpdateMainControllerInternal(
|
|||
|
||||
if (!mMainController) {
|
||||
LOG_MAINCONTROLLER_INFO("Clear main controller");
|
||||
mSource->SetControlledTabBrowsingContextId(Nothing());
|
||||
mSource->SetPlaybackState(MediaSessionPlaybackState::None);
|
||||
mSource->SetMediaMetadata(MediaMetadataBase::EmptyData());
|
||||
mSource->SetSupportedMediaKeys(MediaKeysArray());
|
||||
|
@ -415,7 +414,6 @@ void MediaControlService::ControllerManager::UpdateMainControllerInternal(
|
|||
} else {
|
||||
LOG_MAINCONTROLLER_INFO("Set controller %" PRId64 " as main controller",
|
||||
mMainController->Id());
|
||||
mSource->SetControlledTabBrowsingContextId(Some(mMainController->Id()));
|
||||
mSource->SetPlaybackState(mMainController->PlaybackState());
|
||||
mSource->SetMediaMetadata(mMainController->GetCurrentMediaMetadata());
|
||||
mSource->SetSupportedMediaKeys(mMainController->GetSupportedMediaKeys());
|
||||
|
|
Загрузка…
Ссылка в новой задаче