Bug 590481 - Menulist are not scrollable [r=mfinkle]

mobile/chrome/content/browser-ui.js

@@ -2094,9 +2094,9 @@ var MenuListHelperUI = {
     for (let i = 0; i < children.length; i++) {
       let child = children[i];
       let item = document.createElement("richlistitem");
-      if (child.selected)
-        item.setAttribute("selected", child.selected);
-      item.setAttribute("class", "menulist-command");
+      // Add selected as a class name instead of an attribute to not being overidden
+      // by the richlistbox behavior (it sets the "current" and "selected" attribute
+      item.setAttribute("class", "menulist-command" + (child.selected ? " selected" : ""));
 
       let label = document.createElement("label");
       label.setAttribute("value", child.label);

mobile/chrome/content/browser.xul

@@ -541,7 +541,7 @@
 
     <hbox id="menulist-container" class="window-width window-height context-block" top="0" left="0" hidden="true" flex="1">
       <vbox id="menulist-popup" class="dialog-dark">
-        <richlistbox id="menulist-commands" onselect="MenuListHelperUI.selectByIndex(this.selectedIndex)"/>
+        <richlistbox id="menulist-commands" onclick="if (event.target != this) MenuListHelperUI.selectByIndex(this.selectedIndex);" flex="1"/>
       </vbox>
     </hbox>
 

mobile/themes/core/browser.css

@@ -1543,9 +1543,9 @@ pageaction:hover:active > vbox > .pageaction-desc {
   background: #8db8d8;
 }
 
-.menulist-command[selected="true"] {
-  pointer-events: none;
+.menulist-command.selected {
   background: #8db8d8;
+  pointer-events: none;
 }
 
 /* context popup ----------------------------------------------------------- */