Bug 1495903 - When running raptor on chromium, remove the webext from the cmd line after each test is finished; r=jmaher

Differential Revision: https://phabricator.services.mozilla.com/D9709

--HG--
extra : moz-landing-system : lando

testing/raptor/raptor/raptor.py

@@ -150,6 +150,8 @@ class Raptor(object):
             self.device.create_socket_connection('reverse', _tcp_port, _tcp_port)
 
         # must intall raptor addon each time because we dynamically update some content
+        # note: for chrome the addon is just a list of paths that ultimately are added
+        # to the chromium command line '--load-extension' argument
         raptor_webext = os.path.join(webext_dir, 'raptor')
         self.log.info("installing webext %s" % raptor_webext)
         self.profile.addons.install(raptor_webext)
@@ -258,11 +260,14 @@ class Raptor(object):
             self.playback.stop()
 
         # remove the raptor webext; as it must be reloaded with each subtest anyway
-        # applies to firefox only; chrome the addon is actually just cmd line arg
+        self.log.info("removing webext %s" % raptor_webext)
         if self.config['app'] in ["firefox", "geckoview"]:
-            self.log.info("removing webext %s" % raptor_webext)
             self.profile.addons.remove_addon(webext_id)
 
+        # for chrome the addon is just a list (appended to cmd line)
+        if self.config['app'] in ["chrome", "chrome-android"]:
+            self.profile.addons.remove(raptor_webext)
+
         if self.config['app'] != "geckoview":
             if self.runner.is_running():
                 self.runner.stop()