Bug 1881055 - Cleanup XUL stack from aboutaddons inline options custom element. r=willdurand,desktop-theme-reviewers,emilio

Depends on D202237

Differential Revision: https://phabricator.services.mozilla.com/D202519

toolkit/mozapps/extensions/content/aboutaddons.css

@@ -643,12 +643,18 @@ panel-item[action="report"]::part(button) {
   text-decoration: none;
 }
 
-.inline-options-stack {
-  /* If the options browser triggers an alert we need room to show it. */
-  min-height: 250px;
+.addon-inline-options {
   width: 100%;
   background-color: white;
   margin-block: 4px;
+  /*
+   * Makes sure the browser minimal height is going to be the same as when
+   * this browser element was wrapper in a stack and a min-height was necessary
+   * for the prompts to fit inside the browser element.
+   * That stack element has been removed as part of Bug 1881055, but keeping
+   * the min-height unchanged to avoid potential regressions in the short term.
+   */
+  min-height: 250px;
 }
 
 addon-permissions-list > .addon-detail-row {

toolkit/mozapps/extensions/content/aboutaddons.js

@@ -1708,6 +1708,7 @@ class InlineOptionsBrowser extends HTMLElement {
     browser.setAttribute("disableglobalhistory", "true");
     browser.setAttribute("messagemanagergroup", "webext-browsers");
     browser.setAttribute("id", "addon-inline-options");
+    browser.setAttribute("class", "addon-inline-options");
     browser.setAttribute("transparent", "true");
     browser.setAttribute("forcemessagemanager", "true");
     browser.setAttribute("autocompletepopup", "PopupAutoComplete");
@@ -1744,12 +1745,7 @@ class InlineOptionsBrowser extends HTMLElement {
       readyPromise = promiseEvent("load", browser, true);
     }
 
-    // TODO(rpl): we can remove this stack element once we are ripping off
-    // the content prompt support (and `prompts.contentPromptSubDialog` pref).
-    let stack = document.createXULElement("stack");
-    stack.classList.add("inline-options-stack");
-    stack.appendChild(browser);
-    this.appendChild(stack);
+    this.appendChild(browser);
     this.browser = browser;
 
     // Force bindings to apply synchronously.