Bug 1668825 - Remove JS_GetTraceThingInfo from the public API since it's only used internally r=sfink

Differential Revision: https://phabricator.services.mozilla.com/D92259

js/public/TracingAPI.h

@@ -510,11 +510,6 @@ extern JS_PUBLIC_API void TraceChildren(JSTracer* trc, GCCellPtr thing);
 
 }  // namespace JS
 
-extern JS_PUBLIC_API void JS_GetTraceThingInfo(char* buf, size_t bufsize,
-                                               JSTracer* trc, void* thing,
-                                               JS::TraceKind kind,
-                                               bool includeDetails);
-
 namespace js {
 
 inline bool IsTracerKind(JSTracer* trc, JS::TracerKind kind) {

js/src/gc/Tracer.cpp

@@ -212,9 +212,8 @@ static const char* StringKindHeader(JSString* str) {
   return "linear: ";
 }
 
-JS_PUBLIC_API void JS_GetTraceThingInfo(char* buf, size_t bufsize,
-                                        JSTracer* trc, void* thing,
-                                        JS::TraceKind kind, bool details) {
+void js::gc::GetTraceThingInfo(char* buf, size_t bufsize, void* thing,
+                               JS::TraceKind kind, bool details) {
   const char* name = nullptr; /* silence uninitialized warning */
   size_t n;
 

js/src/gc/Tracer.h

@@ -295,6 +295,10 @@ void TraceCycleCollectorChildren(JS::CallbackTracer* trc, ObjectGroup* group);
  */
 void TraceIncomingCCWs(JSTracer* trc, const JS::CompartmentSet& compartments);
 
+/* Get information about a GC thing. Used when dumping the heap. */
+void GetTraceThingInfo(char* buf, size_t bufsize, void* thing,
+                       JS::TraceKind kind, bool includeDetails);
+
 }  // namespace gc
 }  // namespace js
 

js/src/util/DumpFunctions.cpp

@@ -570,8 +570,8 @@ static void DumpHeapVisitCell(JSRuntime* rt, void* data, JS::GCCellPtr cellptr,
                               const JS::AutoRequireNoGC& nogc) {
   DumpHeapTracer* dtrc = static_cast<DumpHeapTracer*>(data);
   char cellDesc[1024 * 32];
-  JS_GetTraceThingInfo(cellDesc, sizeof(cellDesc), dtrc, cellptr.asCell(),
-                       cellptr.kind(), true);
+  js::gc::GetTraceThingInfo(cellDesc, sizeof(cellDesc), cellptr.asCell(),
+                        cellptr.kind(), true);
 
   fprintf(dtrc->output, "%p %c %s", cellptr.asCell(),
           MarkDescriptor(cellptr.asCell()), cellDesc);