From c77cc571d8e7b6696c7734a13331efb622d73092 Mon Sep 17 00:00:00 2001 From: Geoffrey Sneddon Date: Thu, 31 Jan 2019 18:56:53 +0000 Subject: [PATCH] Bug 1523562 [wpt PR 14924] - Bug #14179: Disable test_run_firefox for flakiness, a=testonly Automatic update from web-platform-tests Rely on /infrastructure as integration tests for FF/Ch (#14924) This fixes #14179 by deleting the flaky test. -- wpt-commits: 4fe523f4391e1314bb4c695b8ffd52b1f621539b wpt-pr: 14924 --- .../tests/tools/wpt/tests/test_wpt.py | 45 ------------------- 1 file changed, 45 deletions(-) diff --git a/testing/web-platform/tests/tools/wpt/tests/test_wpt.py b/testing/web-platform/tests/tools/wpt/tests/test_wpt.py index 0f1dcb7fd814..bf6250f29035 100644 --- a/testing/web-platform/tests/tools/wpt/tests/test_wpt.py +++ b/testing/web-platform/tests/tools/wpt/tests/test_wpt.py @@ -161,51 +161,6 @@ def test_list_tests_invalid_manifest(manifest_dir): assert excinfo.value.code == 0 -@pytest.mark.slow -@pytest.mark.remote_network -@pytest.mark.xfail(sys.platform == "win32", - reason="Tests currently don't work on Windows for path reasons") -def test_run_firefox(manifest_dir): - # TODO: It seems like there's a bug in argparse that makes this argument order required - # should try to work around that - if is_port_8000_in_use(): - pytest.skip("port 8000 already in use") - - if sys.platform == "darwin": - fx_path = os.path.join(wpt.localpaths.repo_root, "_venv", "browsers", "nightly", "Firefox Nightly.app") - else: - fx_path = os.path.join(wpt.localpaths.repo_root, "_venv", "browsers", "nightly", "firefox") - if os.path.exists(fx_path): - shutil.rmtree(fx_path) - with pytest.raises(SystemExit) as excinfo: - wpt.main(argv=["run", "--no-pause", "--install-browser", "--yes", - # The use of `--binary-args` is intentional: it - # demonstrates that internally-managed command-line - # arguments are properly merged with those specified by - # the user. See - # https://github.com/web-platform-tests/wpt/pull/13154 - "--binary-arg=-headless", - "--metadata", manifest_dir, - "firefox", "/dom/nodes/Element-tagName.html"]) - assert os.path.exists(fx_path) - shutil.rmtree(fx_path) - assert excinfo.value.code == 0 - - -@pytest.mark.slow -@pytest.mark.xfail(sys.platform == "win32", - reason="Tests currently don't work on Windows for path reasons") -def test_run_chrome(manifest_dir): - if is_port_8000_in_use(): - pytest.skip("port 8000 already in use") - - with pytest.raises(SystemExit) as excinfo: - wpt.main(argv=["run", "--yes", "--no-pause", "--binary-arg", "headless", - "--metadata", manifest_dir, - "chrome", "/dom/nodes/Element-tagName.html"]) - assert excinfo.value.code == 0 - - @pytest.mark.slow @pytest.mark.remote_network @pytest.mark.xfail(sys.platform == "win32",