Bug 1746662 - Disable CreateSamplingRestrictedDrawable.

Differential Revision: https://phabricator.services.mozilla.com/D155149

gfx/thebes/gfxUtils.cpp

@@ -290,7 +290,10 @@ static already_AddRefed<gfxDrawable> CreateSamplingRestrictedDrawable(
   AUTO_PROFILER_LABEL("CreateSamplingRestrictedDrawable", GRAPHICS);
 
   DrawTarget* destDrawTarget = aContext->GetDrawTarget();
-  if (destDrawTarget->GetBackendType() == BackendType::DIRECT2D1_1) {
+  // We've been not using CreateSamplingRestrictedDrawable in a bunch of places
+  // for a while. Let's disable it everywhere and confirm that it's ok to get rid
+  // of.
+  if (destDrawTarget->GetBackendType() == BackendType::DIRECT2D1_1 || (true)) {
     return nullptr;
   }
 

layout/reftests/border-image/reftest.list

@@ -17,8 +17,8 @@ fuzzy-if(winWidget,0-1,0-1) == multicolor-image-2.html multicolor-image-2-ref.ht
 != different-h-v-2.html different-h-v-ref.html
 != different-h-v-1.html different-h-v-2.html
 == center-scaling-1.html center-scaling-1-ref.html
-== center-scaling-2.html center-scaling-2-ref.html # Android: very different scaling (blurriness) on some sides
-== center-scaling-3.html center-scaling-3-ref.html # Android: very different scaling (blurriness) on some sides
+fuzzy-if(useDrawSnapshot,35-35,4050-4050) == center-scaling-2.html center-scaling-2-ref.html # Android: very different scaling (blurriness) on some sides
+fuzzy-if(useDrawSnapshot,35-35,5220-5220) == center-scaling-3.html center-scaling-3-ref.html # Android: very different scaling (blurriness) on some sides
 == center-scaling-4t.html center-scaling-4t-ref.html
 == center-scaling-4r.html center-scaling-4r-ref.html
 == center-scaling-4b.html center-scaling-4b-ref.html

layout/reftests/bugs/reftest.list

@@ -994,7 +994,7 @@ fuzzy(0-92,0-430) == chrome://reftest/content/bugs/421203-2.xhtml 421203-1-ref.h
 == 421436-1b.html 421436-1-ref.html
 fuzzy(0-1,0-40) == 421632-1.html 421632-1-ref.html
 != 421710-1.html about:blank
-fails-if(Android) fuzzy-if(!useDrawSnapshot,63-65,1024-1024) fails-if(usesRepeatResampling&&!winWidget) == 421885-1.xml 421885-1-ref.xml
+fails-if(Android) fuzzy(63-65,1024-1024) fails-if(usesRepeatResampling&&!winWidget) == 421885-1.xml 421885-1-ref.xml
 == 421955-1.html 421955-1-ref.html
 == 422249-1.html 422249-1-ref.html
 == 422394-1.html 422394-1-ref.html

layout/reftests/image-element/reftest.list

@@ -23,7 +23,8 @@ fuzzy-if(d2d,0-255,0-24) fuzzy-if(!useDrawSnapshot,255-255,50-115) == element-pa
 # For the rest: -ref the scrollframe is active and layerized differently with APZ.
 fuzzy(0-24,0-106) fuzzy-if(winWidget&&!layersGPUAccelerated,149-149,1203-1203) fuzzy-if(!useDrawSnapshot&&!nativeThemePref,1-48,5-68) fuzzy-if(winWidget,47-222,1197-1588) fuzzy-if(Android,0-40,0-81) == element-paint-native-widget.html element-paint-native-widget-ref.html
 
-fails-if(usesRepeatResampling&&!winWidget) == element-paint-subimage-sampling-restriction.html about:blank
+# This fails with CreateSamplingRestrictedDrawable removed
+fails-if(!Android&&!useDrawSnapshot) == element-paint-subimage-sampling-restriction.html about:blank
 == element-paint-clippath.html element-paint-clippath-ref.html
 fuzzy-if(!useDrawSnapshot,1-1,128-128) fuzzy-if(d2d,47-47,650-652) fuzzy-if(!useDrawSnapshot,36-39,704-738) == element-paint-sharpness-01a.html element-paint-sharpness-01b.html
 fuzzy(0-1,0-326) fails-if(useDrawSnapshot) == element-paint-sharpness-01b.html element-paint-sharpness-01c.html