Bugzilla bug 244231: added new make variable MOZ_DEBUG_SYMBOLS which

generates debug symbols for optimized builds in PDB files.  Also took the
opportunity to remove -DEBUGTYPE:CV, which is the default and will be
removed in MSVC .NET 2005.  The patch is contributed by Brian Ryner of IBM
<bryner@brianryner.com>. r=wtc.
Modified Files:
	WIN32.mk WIN954.0.mk WINCE3.0.mk WINNT3.51.mk WINNT4.0.mk
	WINNT5.0.mk WINNT5.1.mk

security/coreconf/WIN32.mk

@@ -120,7 +120,12 @@ else # !NS_USE_GCC
 	#
 	ifdef MOZ_PROFILE
 		OPTIMIZER += -Z7
-		DLLFLAGS += -DEBUG -DEBUGTYPE:CV
+	endif
+	ifdef MOZ_DEBUG_SYMBOLS
+		OPTIMIZER += -Zi
+	endif
+	ifneq (,$(MOZ_PROFILE)$(MOZ_DEBUG_SYMBOLS))
+		DLLFLAGS += -DEBUG -OPT:REF
 	endif
     else
 	#
@@ -139,9 +144,9 @@ else # !NS_USE_GCC
 	USERNAME   := $(subst $(SPACE),_,$(USERNAME))
 	USERNAME   := $(subst -,_,$(USERNAME))
 	DEFINES    += -DDEBUG -D_DEBUG -UNDEBUG -DDEBUG_$(USERNAME)
-	DLLFLAGS   += -DEBUG -DEBUGTYPE:CV -OUT:"$@"
+	DLLFLAGS   += -DEBUG -OUT:"$@"
 	# Purify requires /FIXED:NO when linking EXEs.
-	LDFLAGS    += -DEBUG -DEBUGTYPE:CV -PDB:NONE /FIXED:NO
+	LDFLAGS    += -DEBUG -PDB:NONE /FIXED:NO
     endif
 endif # NS_USE_GCC
 

security/coreconf/WIN954.0.mk

@@ -62,6 +62,9 @@ else
 endif
 
 ifndef NS_USE_GCC
-OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS -PDB:NONE
+OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS
+ifndef MOZ_DEBUG_SYMBOLS
+OS_DLLFLAGS += -PDB:NONE
+endif
 endif
 DEFINES += -DWIN95

security/coreconf/WINCE3.0.mk

@@ -69,7 +69,7 @@ OS_CFLAGS += -W3 -nologo
 
 OS_DLLFLAGS += -DLL 
 
-LINKFLAGS = -nologo -PDB:NONE -subsystem:windowsce,3.00 \
+LINKFLAGS = -nologo -subsystem:windowsce,3.00 \
  -nodefaultlib:libc.lib \
  -nodefaultlib:libcd.lib \
  -nodefaultlib:libcmt.lib \
@@ -79,6 +79,10 @@ LINKFLAGS = -nologo -PDB:NONE -subsystem:windowsce,3.00 \
  -nodefaultlib:oldnames.lib \
  $(NULL)
 
+ifndef MOZ_DEBUG_SYMBOLS
+LINKFLAGS += -PDB:NONE
+endif
+
 LINK    += $(LINKFLAGS)
 LDFLAGS += $(LINKFLAGS)
 

security/coreconf/WINNT3.51.mk

@@ -60,7 +60,11 @@ endif
 OS_WIN_CFLAGS += -W3
 OS_CFLAGS     += -nologo $(OS_WIN_CFLAGS) $(OS_PROC_CFLAGS)
 #OS_DLLFLAGS  += -nologo -DLL -PDB:NONE -SUBSYSTEM:WINDOWS
-OS_DLLFLAGS   += -nologo -DLL -PDB:NONE -SUBSYSTEM:WINDOWS
+OS_DLLFLAGS   += -nologo -DLL -SUBSYSTEM:WINDOWS
+ifndef MOZ_DEBUG_SYMBOLS
+OS_DLLFLAGS   += -PDB:NONE
+endif
+
 #
 # Win NT needs -GT so that fibers can work
 #

security/coreconf/WINNT4.0.mk

@@ -59,7 +59,11 @@ else
 	endif
 endif
 
-OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS -PDB:NONE
+OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS
+ifndef MOZ_DEBUG_SYMBOLS
+OS_DLLFLAGS += -PDB:NONE
+endif
+
 #
 # Win NT needs -GT so that fibers can work
 #

security/coreconf/WINNT5.0.mk

@@ -59,7 +59,11 @@ else
 	endif
 endif
 
-OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS -PDB:NONE
+OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS
+ifndef MOZ_DEBUG_SYMBOLS
+OS_DLLFLAGS += -PDB:NONE
+endif
+
 #
 # Win NT needs -GT so that fibers can work
 #

security/coreconf/WINNT5.1.mk

@@ -59,7 +59,11 @@ else
 	endif
 endif
 
-OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS -PDB:NONE
+OS_DLLFLAGS += -nologo -DLL -SUBSYSTEM:WINDOWS
+ifndef MOZ_DEBUG_SYMBOLS
+OS_DLLFLAGS += -PDB:NONE
+endif
+
 #
 # Win NT needs -GT so that fibers can work
 #