Bug 1690785 - Update of the contribution doc wrt check-in needed r=jwalker,aryx DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D104057
This commit is contained in:
Sylvestre Ledru 2021-02-04 21:52:38 +00:00
Родитель 900774169e
Коммит c9c024db93
4 изменённых файлов: 13 добавлений и 27 удалений

Просмотреть файл

@ -15,6 +15,4 @@ Once a review has been approved, someone with enough privileges can request the
If you don't have the privileges, you can also ask your mentor to land the code. In fact, they might even initiate that for you once the code review is approved.
To request the landing, add the *Check-in Needed* Tags to the review (*Edit Revision*).
Someone looks at review marked with `Check-in Needed` a few times a day, verifies they have an associated **approved** review, and then attempts to land them.
To request the landing, ask your reviewer to land the patch.

Просмотреть файл

@ -263,12 +263,18 @@ To pull changes from the repository, run:
# Git
$ git pull --rebase
.. _push_a_change:
To push a change in the code base
---------------------------------
Once the change has been accepted and you've fixed any remaining issues
the reviewer identified, add the *Check-in Needed* tag to the review
(use the *Edit Revision* option on the top right).
the reviewer identified, the reviewer should land the patch.
If the patch has not landed on "autoland" (the integration branch) after a few days,
feel free to contact the reviewer and/or
@Aryx or @Sylvestre on the `#introduction <https://chat.mozilla.org/#/room/#introduction:mozilla.org>`__
channel.
The landing procedure will automatically close the review and the bug.

Просмотреть файл

@ -243,17 +243,8 @@ reviewed.
completing all necessary verifications.
Add the tag "check-in needed" on the revision(s) in phabricator. To do
so, click on the "Edit" button on a phabricator revision, and start
typing "check-in needed" in the Tags field. It should auto-complete. If
Phabricator doesn't allow you to add the keyword, ask someone else to
add it. Community members with commit access, regularly search for
revisions with the checkin-needed keyword, often committing in a day or
so. If the patch does not get checked, within a reasonable timeframe,
join #developers on `chat.mozilla.org <https://chat.mozilla.org>`__, asking
someone to check on your behalf. In most circumstances, a link to a
passing Try run will be required, in order to verify the patch will not
cause any new failures after landing.
Ask the reviewer to land the patch for you.
For more details, see :ref:`push_a_change`
If pushing the patch yourself, please follow :ref:`Committing rules and responsibilities`.
`Lando <https://moz-conduit.readthedocs.io/en/latest/lando-user.html>`__ is used

Просмотреть файл

@ -154,18 +154,9 @@ making sure there are no unexpected regressions. If you don't have try
server access already, your mentor, or the person who reviewed your
patch, will be able to help.
Once you have a **green** try server run, mark that your patch is ready
to commit by
Ask the reviewer to land the patch for you.
For more details, see :ref:`push_a_change`
#. opening the Phabricator page for your patch
#. clicking the 'Edit Revision' link in the sidebar on the right
#. then into the 'Tags' field and
#. typing 'Check-In Needed' to get the tag added.
A friendly Mozillian, with commit access, will be along shortly to push
your patch to the repository, and update the bug as required. If your
patch passes all Mozilla's automated testing, it will soon be merged
into the main branch, and become a part of the Nightly build.
Do it all again!
----------------