Bug 1109699 - Fix more bad implicit constructors in gfx and image; r=jrmuizel

gfx/2d/DrawTargetCG.h

@@ -96,7 +96,7 @@ class GlyphRenderingOptionsCG : public GlyphRenderingOptions
 public:
   MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(GlyphRenderingOptionsCG)
 
-  GlyphRenderingOptionsCG(const Color &aFontSmoothingBackgroundColor)
+  explicit GlyphRenderingOptionsCG(const Color &aFontSmoothingBackgroundColor)
     : mFontSmoothingBackgroundColor(aFontSmoothingBackgroundColor)
   {}
 

gfx/gl/SharedSurface.cpp

@@ -459,7 +459,7 @@ class AutoLockBits
     uint8_t* mLockedBits;
 
 public:
-    AutoLockBits(gfx::DrawTarget* dt)
+    explicit AutoLockBits(gfx::DrawTarget* dt)
         : mDT(dt)
         , mLockedBits(nullptr)
     {

gfx/gl/SharedSurface.h

@@ -284,7 +284,7 @@ class ScopedReadbackFB
     SharedSurface* mSurfToLock;
 
 public:
-    ScopedReadbackFB(SharedSurface* src);
+    explicit ScopedReadbackFB(SharedSurface* src);
     ~ScopedReadbackFB();
 };
 

gfx/layers/GLImages.h

@@ -20,7 +20,7 @@ namespace layers {
 
 class GLImage : public Image {
 public:
-  GLImage(ImageFormat aFormat) : Image(nullptr, aFormat){}
+  explicit GLImage(ImageFormat aFormat) : Image(nullptr, aFormat){}
 
   virtual TemporaryRef<gfx::SourceSurface> GetAsSourceSurface() MOZ_OVERRIDE;
 };

gfx/layers/ipc/CompositorParent.h

@@ -100,7 +100,7 @@ class CompositorVsyncObserver MOZ_FINAL : public VsyncObserver
   friend class CompositorParent;
 
 public:
-  CompositorVsyncObserver(CompositorParent* aCompositorParent);
+  explicit CompositorVsyncObserver(CompositorParent* aCompositorParent);
   virtual bool NotifyVsync(TimeStamp aVsyncTimestamp) MOZ_OVERRIDE;
   void SetNeedsComposite(bool aSchedule);
   bool NeedsComposite();

gfx/src/nsRenderingContext.h

@@ -24,15 +24,15 @@ class MOZ_STACK_CLASS nsRenderingContext MOZ_FINAL
 public:
     nsRenderingContext() {}
 
-    nsRenderingContext(gfxContext* aThebesContext)
+    explicit nsRenderingContext(gfxContext* aThebesContext)
       : mThebes(aThebesContext)
     {}
 
-    nsRenderingContext(already_AddRefed<gfxContext>&& aThebesContext)
+    explicit nsRenderingContext(already_AddRefed<gfxContext>&& aThebesContext)
       : mThebes(aThebesContext)
     {}
 
-    nsRenderingContext(DrawTarget* aDrawTarget) {
+    explicit nsRenderingContext(DrawTarget* aDrawTarget) {
       Init(aDrawTarget);
     }
 

gfx/thebes/ContextStateTracker.h

@@ -34,7 +34,7 @@ protected:
 
   class ContextState {
   public:
-    ContextState(const char* aSectionName)
+    explicit ContextState(const char* aSectionName)
       : mSectionName(aSectionName)
     {}
 

gfx/thebes/gfxFontEntry.h

@@ -63,7 +63,7 @@ public:
         mHash(0), mBuildOnTheFly(false), mShared(false)
     { }
 
-    gfxCharacterMap(const gfxSparseBitSet& aOther) :
+    explicit gfxCharacterMap(const gfxSparseBitSet& aOther) :
         gfxSparseBitSet(aOther),
         mHash(0), mBuildOnTheFly(false), mShared(false)
     { }

gfx/thebes/gfxPlatform.cpp

@@ -164,7 +164,7 @@ public:
 class CrashStatsLogForwarder: public mozilla::gfx::LogForwarder
 {
 public:
-  CrashStatsLogForwarder(const char* aKey);
+  explicit CrashStatsLogForwarder(const char* aKey);
   virtual void Log(const std::string& aString) MOZ_OVERRIDE;
 
   void SetCircularBufferSize(uint32_t aCapacity);

gfx/thebes/gfxVR.cpp

@@ -180,7 +180,7 @@ using namespace mozilla::gfx;
 class FakeScreen : public nsIScreen
 {
 public:
-  FakeScreen(const IntRect& aScreenRect)
+  explicit FakeScreen(const IntRect& aScreenRect)
     : mScreenRect(aScreenRect)
   { }
 
@@ -230,7 +230,7 @@ NS_IMPL_ISUPPORTS(FakeScreen, nsIScreen)
 class HMDInfoOculus : public VRHMDInfo {
   friend class VRHMDManagerOculusImpl;
 public:
-  HMDInfoOculus(ovrHmd aHMD);
+  explicit HMDInfoOculus(ovrHmd aHMD);
 
   bool SetFOV(const VRFieldOfView& aFOVLeft, const VRFieldOfView& aFOVRight,
               double zNear, double zFar) MOZ_OVERRIDE;

gfx/thebes/gfxVR.h

@@ -182,7 +182,7 @@ public:
   virtual nsIScreen* GetScreen() { return mScreen; }
 
 protected:
-  VRHMDInfo(VRHMDType aType) : mType(aType) { MOZ_COUNT_CTOR(VRHMDInfo); }
+  explicit VRHMDInfo(VRHMDType aType) : mType(aType) { MOZ_COUNT_CTOR(VRHMDInfo); }
   virtual ~VRHMDInfo() { MOZ_COUNT_DTOR(VRHMDInfo); }
 
   VRHMDType mType;

image/src/DecodePool.cpp

@@ -111,7 +111,7 @@ private:
 class DecodeWorker : public nsRunnable
 {
 public:
-  DecodeWorker(RasterImage* aImage)
+  explicit DecodeWorker(RasterImage* aImage)
     : mImage(aImage)
   { }