misuse of '==' for 'eq'.

webtools/tinderbox2/src/lib/BonsaiData.pm

@@ -7,8 +7,8 @@
 # module which uses this library is: lib/TinderDB/VC_Bonsai.pm
 
 
-# $Revision: 1.10 $ 
-# $Date: 2002/04/25 23:46:10 $ 
+# $Revision: 1.11 $ 
+# $Date: 2002/05/03 04:40:08 $ 
 # $Author: kestes%walrus.com $ 
 # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/lib/BonsaiData.pm,v $ 
 # $Name:  $ 
@@ -313,10 +313,10 @@ sub save_tree_state {
 
   LoadCheckins();
 
-  if ($value == 'Open') {
+  if ($value eq 'Open') {
       $clear_list_of_checkins=1;
       AdminOpenTree($time_now, $clear_list_of_checkins);
-  } elsif ($value == 'Closed') {
+  } elsif ($value eq 'Closed') {
       AdminCloseTree($time_now);
   } else {
       die("Bonsai does not implement TreeState: $value\n");

webtools/tinderbox2/src/lib/TinderDB.pm

@@ -19,8 +19,8 @@
 #       notice board display,  build display (colored squares)
 
 
-# $Revision: 1.11 $ 
-# $Date: 2002/05/03 04:33:30 $ 
+# $Revision: 1.12 $ 
+# $Date: 2002/05/03 04:44:05 $ 
 # $Author: kestes%walrus.com $ 
 # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/lib/TinderDB.pm,v $ 
 # $Name:  $ 
@@ -152,11 +152,8 @@ $MAX_UPDATES_SINCE_TRIM = $TinderConfig::DB_MAX_UPDATES_SINCE_TRIM || (50);
 
 $TRIM_SECONDS = $TinderConfig::DB_TRIM_SECONDS || (60 * 60 * 24 * 8);
 
-if (defined($TinderConfig::UNIFORM_ROW_SPACING)) {
-    $UNIFORM_ROW_SPACING = $TinderConfig::UNIFORM_ROW_SPACING;
-} else {
-    $UNIFORM_ROW_SPACING = 1;
-}
+$ROW_SPACING_DISIPLINE = $TinderConfig::ROW_SPACING_DISIPLINE ||
+    'uniform';
 
 # The DB implemenations are sourced in TinderConfig.pm just before
 # this wrapper class is sourced.  It is expected that the
@@ -493,13 +490,13 @@ sub status_table_body {
   # we have data for.
 
   my ($row_times);
-  if      ($ROW_SPACING_DISIPLINE == 'uniform') {
+  if      ($ROW_SPACING_DISIPLINE eq 'uniform') {
       $row_times = construct_uniform_times_vec($start_time, $end_time, 
                                                $TABLE_SPACING,);
-  } elsif ($ROW_SPACING_DISIPLINE == 'event_driven') {
+  } elsif ($ROW_SPACING_DISIPLINE eq 'event_driven') {
       $row_times = construct_event_times_vec($start_time, $end_time, 
                                              $tree);
-  } elsif ($ROW_SPACING_DISIPLINE == 'build_event_driven') {
+  } elsif ($ROW_SPACING_DISIPLINE eq 'build_event_driven') {
       $row_times = construct_build_event_times_vec($start_time, $end_time, 
                                                     $tree);
   } else {

webtools/tinderbox2/src/lib/TinderDB/Build.pm

@@ -7,8 +7,8 @@
 # the build was and display a link to the build log.
 
 
-# $Revision: 1.41 $ 
-# $Date: 2002/05/02 22:11:32 $ 
+# $Revision: 1.42 $ 
+# $Date: 2002/05/03 04:40:05 $ 
 # $Author: kestes%walrus.com $ 
 # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/lib/TinderDB/Build.pm,v $ 
 # $Name:  $ 
@@ -164,6 +164,8 @@ $VERSION = '#tinder_version#';
 $EMPTY_TABLE_CELL = $HTMLPopUp::EMPTY_TABLE_CELL ||
     " ";
 
+$DISPLAY_BUILD_ERRORS = $TinderConfig::DISPLAY_BUILD_ERRORS  ||
+    1;
 
 # Find the name of each build and the proper order to display them.
 # No part of the code should peek at keys %{ $DATABASE{$tree} } directly.
@@ -1186,9 +1188,7 @@ sub status_table_row {
 
     # Error count (not a link, but hey)
 
-    if ( (BuildStatus::get_display_number_errors) &&
-         ($current_rec->{'errors'}) 
-         ){
+    if ( ($DISPLAY_BUILD_ERRORS) && ($current_rec->{'errors'}) ) {
         $links .= (
                    "\t\t<br>errs: ". 
                    $current_rec->{'errors'}."\n".