Bug 1028588 - Fix more, recently introduced dangerous public destructors - r=ehsan

content/base/src/DOMMatrix.h

@@ -43,10 +43,6 @@ public:
     SetIsDOMBinding();
   }
 
-  ~DOMMatrixReadOnly()
-  {
-  }
-
 #define GetMatrixMember(entry2D, entry3D, default) \
 { \
   if (mMatrix3D) { \
@@ -135,6 +131,10 @@ protected:
   nsCOMPtr<nsISupports>     mParent;
   nsAutoPtr<gfx::Matrix>    mMatrix2D;
   nsAutoPtr<gfx::Matrix4x4> mMatrix3D;
+
+  ~DOMMatrixReadOnly()
+  {
+  }
 private:
   DOMMatrixReadOnly() MOZ_DELETE;
   DOMMatrixReadOnly(const DOMMatrixReadOnly&) MOZ_DELETE;
@@ -248,6 +248,8 @@ public:
   DOMMatrix* SetMatrixValue(const nsAString& aTransformList, ErrorResult& aRv);
 private:
   void Ensure3DMatrix();
+
+  ~DOMMatrix() {}
 };
 
 }

content/canvas/src/WebGLContext.h

@@ -1385,7 +1385,6 @@ public:
     NS_DECL_NSIDOMEVENTLISTENER
 
     WebGLObserver(WebGLContext* aContext);
-    ~WebGLObserver();
 
     void Destroy();
 
@@ -1396,6 +1395,8 @@ public:
     void UnregisterMemoryPressureEvent();
 
 private:
+    ~WebGLObserver();
+
     WebGLContext* mContext;
 };
 

dom/datastore/DataStoreDB.cpp

@@ -68,6 +68,8 @@ public:
 
 private:
   IDBDatabase* mDatabase;
+
+  ~VersionChangeListener() {}
 };
 
 NS_IMPL_ISUPPORTS(VersionChangeListener, nsIDOMEventListener)

dom/workers/ServiceWorkerManager.cpp

@@ -213,6 +213,9 @@ class ServiceWorkerUpdateInstance MOZ_FINAL : public nsISupports
   nsCOMPtr<nsPIDOMWindow> mWindow;
 
   bool mAborted;
+
+  ~ServiceWorkerUpdateInstance() {}
+
 public:
   NS_DECL_ISUPPORTS
 

netwerk/system/mac/nsNetworkLinkService.h

@@ -19,11 +19,13 @@ public:
     NS_DECL_NSIOBSERVER
 
     nsNetworkLinkService();
-    virtual ~nsNetworkLinkService();
 
     nsresult Init();
     nsresult Shutdown();
 
+protected:
+    virtual ~nsNetworkLinkService();
+
 private:
     bool mLinkUp;
     bool mStatusKnown;

widget/xpwidgets/nsBaseClipboard.h

@@ -25,7 +25,6 @@ class nsBaseClipboard : public nsIClipboard
 
 public:
   nsBaseClipboard();
-  virtual ~nsBaseClipboard();
 
   //nsISupports
   NS_DECL_ISUPPORTS
@@ -34,6 +33,7 @@ public:
   NS_DECL_NSICLIPBOARD
   
 protected:
+  virtual ~nsBaseClipboard();
 
   NS_IMETHOD SetNativeClipboardData ( int32_t aWhichClipboard ) = 0;
   NS_IMETHOD GetNativeClipboardData ( nsITransferable * aTransferable, int32_t aWhichClipboard ) = 0;

xpcom/base/nsMemoryReporterManager.cpp

@@ -890,6 +890,9 @@ public:
 
     return NS_OK;
   }
+
+private:
+  ~DMDReporter() {}
 };
 NS_IMPL_ISUPPORTS(DMDReporter, nsIMemoryReporter)
 
@@ -2009,6 +2012,9 @@ public:
     // Do nothing;  the reporter has already reported to DMD.
     return NS_OK;
   }
+
+private:
+  ~DoNothingCallback() {}
 };
 
 NS_IMPL_ISUPPORTS(DoNothingCallback, nsIHandleReportCallback)