Bug 1683188 - BrowserChild::MakeHidden() shouldn't mess with tab state. r=nika

I flagged this as sketchy before (though it was trying to preserve
existing behavior).

However now that that state propagates to the parent process and races
with the state that the parent process reads, it started causing
correctness issues.

Just remove this line, it shouldn't be needed. I'm not sure how to write
a test for this, unfortunately :(

Differential Revision: https://phabricator.services.mozilla.com/D100971
This commit is contained in:
Emilio Cobos Álvarez 2021-01-08 00:48:26 +00:00
Родитель ec8a8ac1ac
Коммит cbe57e88f7
1 изменённых файлов: 0 добавлений и 8 удалений

Просмотреть файл

@ -2898,14 +2898,6 @@ void BrowserChild::MakeHidden() {
} }
} }
// FIXME(emilio): The lack of parallelism between this and MakeVisible is a
// bit suspect, but I guess we don't always want the front-end to manage the
// tab visibility.
if (mIsTopLevel && mBrowsingContext && mBrowsingContext->IsActive()) {
Unused << mBrowsingContext->SetExplicitActive(
dom::ExplicitActiveStatus::None);
}
if (mPuppetWidget) { if (mPuppetWidget) {
mPuppetWidget->Show(false); mPuppetWidget->Show(false);
} }