Backed out changeset 4bad0524f4b8 (bug 1873049) for causing devtool failures CLOSED TREE

browser/base/content/test/tabs/browser.toml

@@ -236,6 +236,7 @@ support-files = [
 ]
 
 ["browser_overflowScroll.js"]
+fail-if = ["a11y_checks"] # Bugs 1854233 and 1873049 scrollbutton-down/up are not labeled
 skip-if = [
   "win11_2009", # Bug 1797751
 ]

toolkit/content/widgets/arrowscrollbox.js

@@ -21,7 +21,7 @@
       return `
       <html:link rel="stylesheet" href="chrome://global/skin/toolbarbutton.css"/>
       <html:link rel="stylesheet" href="chrome://global/skin/arrowscrollbox.css"/>
-      <toolbarbutton id="scrollbutton-up" part="scrollbutton-up" keyNav="false" data-l10n-id="overflow-scroll-button-up"/>
+      <toolbarbutton id="scrollbutton-up" part="scrollbutton-up" keyNav="false"/>
       <spacer part="overflow-start-indicator"/>
       <box class="scrollbox-clip" part="scrollbox-clip" flex="1">
         <scrollbox part="scrollbox" flex="1">
@@ -29,7 +29,7 @@
         </scrollbox>
       </box>
       <spacer part="overflow-end-indicator"/>
-      <toolbarbutton id="scrollbutton-down" part="scrollbutton-down" keyNav="false" data-l10n-id="overflow-scroll-button-down"/>
+      <toolbarbutton id="scrollbutton-down" part="scrollbutton-down" keyNav="false"/>
     `;
     }
 
@@ -43,9 +43,6 @@
       this._scrollButtonDown =
         this.shadowRoot.getElementById("scrollbutton-down");
 
-      MozXULElement.insertFTLIfNeeded("toolkit/global/arrowscrollbox.ftl");
-      document.l10n.connectRoot(this.shadowRoot);
-
       this._arrowScrollAnim = {
         scrollbox: this,
         requestHandle: 0,

toolkit/locales/en-US/toolkit/global/arrowscrollbox.ftl

@@ -1,20 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-### This file contains the entities needed to use the Arrowscrollbox component.
-### For example, Arrowscrollboxes are used in Tabs Toolbar when there are
-### multiple tabs opened and in the overflowing menus.
-
-# This button is shown at the beginning of the overflowing list of elements.
-# For example, in LTR language like English, on the Tabs Toolbar it would look
-# like "<" and scroll the tab list to the left, and in the overflowing menu it
-# would look like "^" and scroll the list of menuitems up.
-overflow-scroll-button-up =
-    .tooltiptext = Scroll up
-# This button is shown at the end of the overflowing list of elements. For
-# example, in LTR language like English, on the Tabs Toolbar it would look like
-# ">" and scroll the tab list to the right, and in the overflowing menu it
-# would look like "v" and scroll the list of menuitems down.
-overflow-scroll-button-down =
-    .tooltiptext = Scroll down