From ccd22bb5d787629f487893b4007b4092cdc4014d Mon Sep 17 00:00:00 2001 From: Byron Campen Date: Thu, 30 Sep 2021 21:58:27 +0000 Subject: [PATCH] Bug 1680620: Remove some log spew that just happens to be causing intermittent failures in browser_WebrtcGlobalInformation.js. r=mjf Differential Revision: https://phabricator.services.mozilla.com/D127162 --- .../transport/third_party/nICEr/src/ice/ice_peer_ctx.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dom/media/webrtc/transport/third_party/nICEr/src/ice/ice_peer_ctx.c b/dom/media/webrtc/transport/third_party/nICEr/src/ice/ice_peer_ctx.c index eb49f64f9e18..38fbfa30bce3 100644 --- a/dom/media/webrtc/transport/third_party/nICEr/src/ice/ice_peer_ctx.c +++ b/dom/media/webrtc/transport/third_party/nICEr/src/ice/ice_peer_ctx.c @@ -240,12 +240,20 @@ int nr_ice_peer_ctx_find_pstream(nr_ice_peer_ctx *pctx, nr_ice_media_stream *str /* Because we don't have forward pointers, iterate through all the peer streams to find one that matches us */ pstream=STAILQ_FIRST(&pctx->peer_streams); + + if(!pstream) { + /* No peer streams at all, presumably because they do not exist yet. + * Don't log a warning here. */ + ABORT(R_NOT_FOUND); + } + while(pstream) { if (pstream->local_stream == stream) break; pstream = STAILQ_NEXT(pstream, entry); } + if (!pstream) { r_log(LOG_ICE,LOG_WARNING,"ICE(%s): peer (%s) has no stream matching stream %s",pctx->ctx->label,pctx->label,stream->label); ABORT(R_NOT_FOUND);