Build bustage on Qt due to macro definition of malloc, realloc, etc. Most of this is just moving Qt #includes around. r=dougt

--HG--
extra : rebase_source : 9734e9e68754a6fc45bddbdc60bb5e898bb8cdb2

content/base/public/nsINode.h

@@ -905,12 +905,12 @@ protected:
       return FlagsAsSlots();
     }
 
-    nsSlots* slots = CreateSlots();
+    nsSlots* newSlots = CreateSlots();
-    if (slots) {
+    if (newSlots) {
-      mFlagsOrSlots = reinterpret_cast<PtrBits>(slots);
+      mFlagsOrSlots = reinterpret_cast<PtrBits>(newSlots);
     }
 
-    return slots;
+    return newSlots;
   }
 
   nsTObserverArray<nsIMutationObserver*> *GetMutationObservers()

gfx/src/thebes/nsSystemFontsQt.cpp

@@ -36,13 +36,14 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include <QApplication>
+#include <QFont>
+
 #include "nsIDeviceContext.h"
 #include "nsIRenderingContext.h"
 
 #include "nsSystemFontsQt.h"
 #include "gfxQtPlatform.h"
-#include <QApplication>
-#include <QFont>
 
 nsSystemFontsQt::nsSystemFontsQt()
   : mDefaultFontName(NS_LITERAL_STRING("sans-serif"))

gfx/thebes/src/gfxFT2Fonts.cpp

@@ -38,8 +38,8 @@
 #include "gfxPlatformGtk.h"
 #define gfxToolkitPlatform gfxPlatformGtk
 #elif defined(MOZ_WIDGET_QT)
-#include "gfxQtPlatform.h"
 #include <qfontinfo.h>
+#include "gfxQtPlatform.h"
 #define gfxToolkitPlatform gfxQtPlatform
 #elif defined(XP_WIN)
 #ifdef WINCE

gfx/thebes/src/gfxQtNativeRenderer.cpp

@@ -35,13 +35,14 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include <QWidget>
+
 #include "gfxQtNativeRenderer.h"
 #include "gfxContext.h"
 
 #include "gfxQtPlatform.h"
 
 #include "cairo.h"
-#include <QWidget>
 
 typedef struct {
     gfxQtNativeRenderer* mRenderer;

layout/generic/nsObjectFrame.cpp

@@ -46,6 +46,13 @@
 
 /* rendering objects for replaced elements implemented by a plugin */
 
+#ifdef MOZ_X11
+#ifdef MOZ_WIDGET_QT
+#include <QWidget>
+#include <QX11Info>
+#endif
+#endif
+
 #include "nscore.h"
 #include "nsCOMPtr.h"
 #include "nsPresContext.h"
@@ -55,12 +62,6 @@
 #include "nsIViewManager.h"
 #include "nsIDOMKeyListener.h"
 #include "nsIDOMDragEvent.h"
-#ifdef MOZ_X11
-#ifdef MOZ_WIDGET_QT
-#include <QWidget>
-#include <QX11Info>
-#endif
-#endif
 #include "nsIPluginHost.h"
 #include "nsString.h"
 #include "nsReadableUtils.h"

modules/libpr0n/decoders/icon/qt/nsIconChannel.cpp

@@ -35,6 +35,10 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include <QIcon>
+#include <QStyle>
+#include <QApplication>
+
 #include <stdlib.h>
 #include <unistd.h>
 
@@ -49,10 +53,6 @@
 #include "nsIconChannel.h"
 #include "nsGtkQtIconsConverter.h"
 
-#include <QIcon>
-#include <QStyle>
-#include <QApplication>
-
 NS_IMPL_ISUPPORTS2(nsIconChannel,
                    nsIRequest,
                    nsIChannel)

toolkit/xre/nsAppRunner.cpp

@@ -48,14 +48,14 @@
 
 #define XPCOM_TRANSLATE_NSGM_ENTRY_POINT 1
 
-#include "nsAppRunner.h"
-#include "nsUpdateDriver.h"
-
 #if defined(MOZ_WIDGET_QT)
 #include <qwidget.h>
 #include <qapplication.h>
 #endif
 
+#include "nsAppRunner.h"
+#include "nsUpdateDriver.h"
+
 #ifdef XP_MACOSX
 #include "MacLaunchHelper.h"
 #include "MacApplicationDelegate.h"

widget/src/qt/mozqwidget.cpp

@@ -1,6 +1,3 @@
-#include "mozqwidget.h"
-#include "nsWindow.h"
-
 #include <QtGui/QApplication>
 #include <QtGui/QCursor>
 #include <QtGui/QInputContext>
@@ -13,6 +10,9 @@
 #include <QtCore/QEvent>
 #include <QtCore/QVariant>
 
+#include "mozqwidget.h"
+#include "nsWindow.h"
+
 
 MozQWidget::MozQWidget(nsWindow* aReceiver, QGraphicsItem* aParent)
     : QGraphicsWidget(aParent),

widget/src/qt/mozqwidget.h

@@ -1,12 +1,12 @@
 #ifndef MOZQWIDGET_H
 #define MOZQWIDGET_H
 
-#include "nsIWidget.h"
-
 #include <QtGui/QApplication>
 #include <QtGui/QGraphicsView>
 #include <QtGui/QGraphicsWidget>
 
+#include "nsIWidget.h"
+
 class QEvent;
 class QPixmap;
 class QWidget;

widget/src/qt/nsAppShell.h

@@ -39,10 +39,9 @@
 #ifndef nsAppShell_h__
 #define nsAppShell_h__
 
+#include <qsocketnotifier.h>
 #include "nsBaseAppShell.h"
 #include "nsCOMPtr.h"
-#include <qsocketnotifier.h>
-
 
 /**
  * Native QT Application shell wrapper

widget/src/qt/nsBidiKeyboard.cpp

@@ -36,11 +36,11 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-#include "nsBidiKeyboard.h"
-
 #include <Qt>
 #include <QApplication>
 
+#include "nsBidiKeyboard.h"
+
 NS_IMPL_ISUPPORTS1(nsBidiKeyboard, nsIBidiKeyboard)
 
 nsBidiKeyboard::nsBidiKeyboard() : nsIBidiKeyboard()

widget/src/qt/nsDragService.cpp

@@ -36,14 +36,14 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include "qmimedata.h"
+#include "qwidget.h"
+
 #include "nsDragService.h"
 #include "nsISupportsPrimitives.h"
 #include "nsXPIDLString.h"
 #include "nsIDOMMouseEvent.h"
 
-#include "qmimedata.h"
-#include "qwidget.h"
-
 NS_IMPL_ADDREF_INHERITED(nsDragService, nsBaseDragService)
 NS_IMPL_RELEASE_INHERITED(nsDragService, nsBaseDragService)
 NS_IMPL_QUERY_INTERFACE2(nsDragService, nsIDragService, nsIDragSession )

widget/src/qt/nsDragService.h

@@ -39,9 +39,10 @@
 #ifndef nsDragService_h__
 #define nsDragService_h__
 
-#include "nsBaseDragService.h"
 #include <qdrag.h>
 
+#include "nsBaseDragService.h"
+
 /* Header file */
 class nsDragService : public nsBaseDragService
 {

widget/src/qt/nsFilePicker.cpp

@@ -37,6 +37,11 @@
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
  * ***** END LICENSE BLOCK ***** */
+
+#include <qfile.h>
+#include <qstringlist.h>
+#include <qapplication.h>
+
 #include "nsFilePicker.h"
 
 #include "nsILocalFile.h"
@@ -48,10 +53,6 @@
 #include "nsReadableUtils.h"
 #include "nsIWidget.h"
 
-#include <qfile.h>
-#include <qstringlist.h>
-#include <qapplication.h>
-
 /* Implementation file */
 NS_IMPL_ISUPPORTS1(nsFilePicker, nsIFilePicker)
 

widget/src/qt/nsFilePicker.h

@@ -40,12 +40,12 @@
 #ifndef NSFILEPICKER_H
 #define NSFILEPICKER_H
 
+#include <qfiledialog.h>
 #include "nsBaseFilePicker.h"
 #include "nsString.h"
 #include "nsIURI.h"
 #include "nsTArray.h"
 #include "nsCOMArray.h"
-#include <qfiledialog.h>
 
 class nsIWidget;
 class nsILocalFile;

widget/src/qt/nsLookAndFeel.cpp

@@ -37,11 +37,13 @@
  * the terms of any one of the MPL, the GPL or the LGPL.
  *
  * ***** END LICENSE BLOCK ***** */
-#include "nsLookAndFeel.h"
 
 #include <QPalette>
 #include <QApplication>
 #include <QStyle>
+
+#include "nsLookAndFeel.h"
+
 #include <qglobal.h>
 
 #undef NS_LOOKANDFEEL_DEBUG

widget/src/qt/nsNativeThemeQt.cpp

@@ -38,8 +38,6 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-#include "nsIFrame.h"
-
 #include <QApplication>
 #include <QStyle>
 #include <QPalette>
@@ -51,6 +49,8 @@
 #include <QFlags>
 #include <QStyleOptionComboBox>
 
+#include "nsIFrame.h"
+
 #include "nsCoord.h"
 #include "nsNativeThemeQt.h"
 #include "nsIDeviceContext.h"

widget/src/qt/nsScreenManagerQt.cpp

@@ -37,12 +37,12 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-#include "nsScreenManagerQt.h"
-#include "nsScreenQt.h"
-
 #include "qdesktopwidget.h"
 #include "qapplication.h"
 
+#include "nsScreenManagerQt.h"
+#include "nsScreenQt.h"
+
 nsScreenManagerQt::nsScreenManagerQt()
 {
     desktop = 0;

widget/src/qt/nsScreenQt.cpp

@@ -37,14 +37,14 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-#include "nsScreenQt.h"
-
 #include <qcolor.h>
 #include <qcolormap.h>
 #include <qrect.h>
 #include <qdesktopwidget.h>
 #include <qapplication.h>
 
+#include "nsScreenQt.h"
+
 nsScreenQt::nsScreenQt(int aScreen)
     : mScreen(aScreen)
 {

widget/src/qt/nsSound.cpp

@@ -36,6 +36,9 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include <QApplication>
+#include <QSound>
+
 #include <string.h>
 
 #include "nscore.h"
@@ -52,9 +55,6 @@
 #include "nsNativeCharsetUtils.h"
 #include "nsAutoPtr.h"
 
-#include <QApplication>
-#include <QSound>
-
 /* used with esd_open_sound */
 static int esdref = -1;
 static PRLibrary *elib = nsnull;

widget/src/qt/nsToolkit.cpp

@@ -38,8 +38,10 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
-#include "nscore.h"  // needed for 'nsnull'
 #include "nsToolkit.h"
+
+#include "nscore.h"  // needed for 'nsnull'
+
 #include "nsGUIEvent.h"
 #include "nsWidgetAtoms.h"
 //#include "plevent.h"

widget/src/qt/nsToolkit.h

@@ -38,9 +38,10 @@
 #ifndef nsToolkit_h__      
 #define nsToolkit_h__
 
+#include <QPixmap>
+
 #include "nsIToolkit.h"
 #include "nsString.h"
-#include <QPixmap>
 
 /**
  * Wrapper around the thread running the message pump.

widget/src/qt/nsWidgetFactory.cpp

@@ -39,13 +39,14 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include "nsWindow.h"
+#include "nsAppShell.h"
+
 #include "nsIGenericFactory.h"
 #include "nsIModule.h"
 
 #include "nsCOMPtr.h"
 #include "nsWidgetsCID.h"
-#include "nsAppShell.h"
-#include "nsWindow.h"
 #include "nsToolkit.h"
 #include "nsHTMLFormatConverter.h"
 #include "nsTransferable.h"

widget/src/qt/nsWindow.cpp

@@ -42,6 +42,25 @@
  *
  * ***** END LICENSE BLOCK ***** */
 
+#include <QtGui/QApplication>
+#include <QtGui/QDesktopWidget>
+#include <QtGui/QCursor>
+#include <QtGui/QIcon>
+#include <QtGui/QX11Info>
+#include <QtGui/QGraphicsScene>
+#include <QtGui/QGraphicsView>
+#include <QtGui/QGraphicsSceneContextMenuEvent>
+#include <QtGui/QGraphicsSceneDragDropEvent>
+#include <QtGui/QGraphicsSceneMouseEvent>
+#include <QtGui/QGraphicsSceneHoverEvent>
+#include <QtGui/QGraphicsSceneWheelEvent>
+#include <QtGui/QGraphicsSceneResizeEvent>
+#include <QtGui/QStyleOptionGraphicsItem>
+
+#include <QtCore/QDebug>
+#include <QtCore/QEvent>
+#include <QtCore/QVariant>
+
 #include "prlink.h"
 
 #include "nsWindow.h"
@@ -66,25 +85,6 @@
 #include "nsIInterfaceRequestorUtils.h"
 #include "nsAutoPtr.h"
 
-#include <QtGui/QApplication>
-#include <QtGui/QDesktopWidget>
-#include <QtGui/QCursor>
-#include <QtGui/QIcon>
-#include <QtGui/QX11Info>
-#include <QtGui/QGraphicsScene>
-#include <QtGui/QGraphicsView>
-#include <QtGui/QGraphicsSceneContextMenuEvent>
-#include <QtGui/QGraphicsSceneDragDropEvent>
-#include <QtGui/QGraphicsSceneMouseEvent>
-#include <QtGui/QGraphicsSceneHoverEvent>
-#include <QtGui/QGraphicsSceneWheelEvent>
-#include <QtGui/QGraphicsSceneResizeEvent>
-#include <QtGui/QStyleOptionGraphicsItem>
-
-#include <QtCore/QDebug>
-#include <QtCore/QEvent>
-#include <QtCore/QVariant>
-
 #include "gfxQtPlatform.h"
 #include "gfxXlibSurface.h"
 #include "gfxQPainterSurface.h"

widget/src/qt/nsWindow.h

@@ -41,16 +41,17 @@
 #ifndef __nsWindow_h__
 #define __nsWindow_h__
 
+#include <QKeyEvent>
+#include <qgraphicswidget.h>
+
 #include "nsAutoPtr.h"
 
 #include "nsBaseWidget.h"
 #include "nsGUIEvent.h"
-#include <QKeyEvent>
 
 #include "nsWeakReference.h"
 
 #include "nsWidgetAtoms.h"
-#include <qgraphicswidget.h>
 
 #ifdef MOZ_LOGGING