Bug 1269486: allow setting ICE controller only once. r=bwc

MozReview-Commit-ID: AXyNyTZH1Jt

--HG--
extra : rebase_source : c8951fd5ada36d5c8ca25568e276fcb8cce0fbfc

media/mtransport/nricectx.cpp

@@ -276,6 +276,7 @@ NrIceCtx::NrIceCtx(const std::string& name,
     gathering_state_(ICE_CTX_GATHER_INIT),
     name_(name),
     offerer_(offerer),
+    ice_controlling_set_(false),
     streams_(),
     ctx_(nullptr),
     peer_(nullptr),
@@ -703,10 +704,13 @@ void NrIceCtx::destroy_peer_ctx() {
 }
 
 nsresult NrIceCtx::SetControlling(Controlling controlling) {
-  peer_->controlling = (controlling == ICE_CONTROLLING)? 1 : 0;
+  if (!ice_controlling_set_) {
+    peer_->controlling = (controlling == ICE_CONTROLLING)? 1 : 0;
+    ice_controlling_set_ = true;
 
-  MOZ_MTLOG(ML_DEBUG, "ICE ctx " << name_ << " setting controlling to" <<
+    MOZ_MTLOG(ML_DEBUG, "ICE ctx " << name_ << " setting controlling to" <<
-            controlling);
+              controlling);
+  }
   return NS_OK;
 }
 

media/mtransport/nricectx.h

@@ -371,6 +371,7 @@ private:
   GatheringState gathering_state_;
   const std::string name_;
   bool offerer_;
+  bool ice_controlling_set_;
   std::vector<RefPtr<NrIceMediaStream> > streams_;
   nr_ice_ctx *ctx_;
   nr_ice_peer_ctx *peer_;