Bug 930674 - Add NO_VISIBILITY_FLAGS to moz.build. r=gps

python/mozbuild/mozbuild/frontend/emitter.py

@@ -171,6 +171,10 @@ class TreeMetadataEmitter(LoggingMixin):
             if sandbox[moz]:
                 passthru.variables[mak] = sandbox[moz]
 
+        # NO_VISIBILITY_FLAGS is slightly different
+        if sandbox['NO_VISIBILITY_FLAGS']:
+            passthru.variables['VISIBILITY_FLAGS'] = ''
+
         varmap = dict(
             ASFILES=('SOURCES', ('.s', '.asm')),
             CSRCS=('SOURCES', '.c'),

python/mozbuild/mozbuild/frontend/sandbox_symbols.py

@@ -257,6 +257,10 @@ VARIABLES = {
         """Whether profile-guided optimization is enabled in this directory.
         """, None),
 
+    'NO_VISIBILITY_FLAGS': (bool, bool, False,
+        """Build sources listed in this file without VISIBILITY_FLAGS.
+        """, None),
+
     'OS_LIBS': (list, list, [],
         """System link libraries.
 

python/mozbuild/mozbuild/test/backend/data/variable_passthru/moz.build

@@ -43,3 +43,4 @@ SOURCES += ['baz.S', 'foo.S']
 FAIL_ON_WARNINGS = True
 LIBXUL_LIBRARY = True
 MSVC_ENABLE_PGO = True
+NO_VISIBILITY_FLAGS = True

python/mozbuild/mozbuild/test/backend/test_recursivemake.py

@@ -358,6 +358,9 @@ class TestRecursiveMakeBackend(BackendTester):
                 'SSRCS += baz.S',
                 'SSRCS += foo.S',
             ],
+            'VISIBILITY_FLAGS': [
+                'VISIBILITY_FLAGS :=',
+            ],
         }
 
         for var, val in expected.items():

python/mozbuild/mozbuild/test/frontend/data/variable-passthru/moz.build

@@ -50,3 +50,4 @@ FORCE_SHARED_LIB = True
 FORCE_STATIC_LIB = True
 EXPORT_LIBRARY = True
 IS_COMPONENT = True
+NO_VISIBILITY_FLAGS = True

python/mozbuild/mozbuild/test/frontend/test_emitter.py

@@ -163,6 +163,7 @@ class TestEmitterBasic(unittest.TestCase):
             SHARED_LIBRARY_LIBS=['fans.sll', 'tans.sll'],
             SIMPLE_PROGRAMS=['fans.x', 'tans.x'],
             SSRCS=['bans.S', 'fans.S'],
+            VISIBILITY_FLAGS='',
         )
 
         variables = objs[1].variables