зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1491236
- Always enable unwind tables on *nix r=froydnj
We were already always enabling it on builds with frame pointers on Android. We now extend this to builds without frame pointers, helping with client-side stacktracing for crashes. It's also the default on many platforms, such as x86-64, whether frame pointer are enabled or not and on x86 with GCC. Somehow, it's not the case for x86 with clang, so this makes clang builds the same as GCC builds in that regard. On ARM, we were always omitting frame pointers because of a GCC bug, but we've not been using GCC for Android builds for a long time (and the GCC bug was actually fixed in 4.7 and backported to 4.6, making it fixed in all versions of GCC we support). Differential Revision: https://phabricator.services.mozilla.com/D6110 --HG-- extra : moz-landing-system : lando
This commit is contained in:
Родитель
be5fea716c
Коммит
cdd1898856
|
@ -7,18 +7,9 @@ dnl disabling frame pointers in this architecture based on the configure
|
||||||
dnl options
|
dnl options
|
||||||
|
|
||||||
AC_DEFUN([MOZ_SET_FRAMEPTR_FLAGS], [
|
AC_DEFUN([MOZ_SET_FRAMEPTR_FLAGS], [
|
||||||
case "$target" in
|
|
||||||
*android*)
|
|
||||||
unwind_tables="-funwind-tables"
|
|
||||||
;;
|
|
||||||
esac
|
|
||||||
if test "$GNU_CC"; then
|
if test "$GNU_CC"; then
|
||||||
MOZ_ENABLE_FRAME_PTR="-fno-omit-frame-pointer $unwind_tables"
|
MOZ_ENABLE_FRAME_PTR="-fno-omit-frame-pointer -funwind-tables"
|
||||||
MOZ_DISABLE_FRAME_PTR="-fomit-frame-pointer"
|
MOZ_DISABLE_FRAME_PTR="-fomit-frame-pointer -funwind-tables"
|
||||||
if test "$CPU_ARCH" = arm; then
|
|
||||||
# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54398
|
|
||||||
MOZ_ENABLE_FRAME_PTR="$unwind_tables"
|
|
||||||
fi
|
|
||||||
else
|
else
|
||||||
case "$target" in
|
case "$target" in
|
||||||
dnl Oy (Frame-Pointer Omission) is only support on x86 compilers
|
dnl Oy (Frame-Pointer Omission) is only support on x86 compilers
|
||||||
|
|
Загрузка…
Ссылка в новой задаче