Bug 1519461 - Don't return values from docShellIsActive, renderLayers, and userTypedValue setters;r=mconley

This is more consistent with other setters, and lets us handle the null frameLoader
case a bit more simply.

Differential Revision: https://phabricator.services.mozilla.com/D16370

--HG--
extra : moz-landing-system : lando

browser/base/content/tabbrowser.js

@@ -492,7 +492,7 @@ window._gBrowser = {
   },
 
   set userTypedValue(val) {
-    return this.selectedBrowser.userTypedValue = val;
+    this.selectedBrowser.userTypedValue = val;
   },
 
   get userTypedValue() {

toolkit/content/widgets/browser-custom-element.js

@@ -379,13 +379,11 @@ class MozBrowser extends MozElementMixin(XULFrameElement) {
     if (this.isRemoteBrowser) {
       let { frameLoader } = this;
       if (frameLoader && frameLoader.tabParent) {
-        return frameLoader.tabParent.docShellIsActive = val;
+        frameLoader.tabParent.docShellIsActive = val;
       }
-      return false;
+    } else if (this.docShell) {
+      this.docShell.isActive = val;
     }
-    if (this.docShell)
-      return this.docShell.isActive = val;
-    return false;
   }
 
   get docShellIsActive() {
@@ -403,11 +401,11 @@ class MozBrowser extends MozElementMixin(XULFrameElement) {
     if (this.isRemoteBrowser) {
       let { frameLoader } = this;
       if (frameLoader && frameLoader.tabParent) {
-        return frameLoader.tabParent.renderLayers = val;
+        frameLoader.tabParent.renderLayers = val;
       }
-      return false;
+    } else {
+      this.docShellIsActive = val;
     }
-    return this.docShellIsActive = val;
   }
 
   get renderLayers() {
@@ -734,7 +732,6 @@ class MozBrowser extends MozElementMixin(XULFrameElement) {
   set userTypedValue(val) {
     this.urlbarChangeTracker.userTyped();
     this._userTypedValue = val;
-    return val;
   }
 
   get userTypedValue() {