From ced33340be983e523b29ad8c66699c16c0e89642 Mon Sep 17 00:00:00 2001
From: "rginda%netscape.com" <rginda%netscape.com>
Date: Thu, 4 Oct 2001 07:38:53 +0000
Subject: [PATCH] bug 103063, venkman strict warnings r=samuel@sieb.net,
 sr=hyatt, a=asa

---
 extensions/venkman/resources/content/outliner-utils.js    | 6 ++++++
 extensions/venkman/resources/content/tree-utils.js        | 6 ++++++
 extensions/venkman/resources/content/venkman-debugger.js  | 4 ++--
 extensions/venkman/resources/content/venkman-handlers.js  | 8 +++++---
 extensions/venkman/resources/content/venkman-outliners.js | 4 ++--
 extensions/venkman/resources/content/venkman-trees.js     | 4 ++--
 6 files changed, 23 insertions(+), 9 deletions(-)

diff --git a/extensions/venkman/resources/content/outliner-utils.js b/extensions/venkman/resources/content/outliner-utils.js
index 36fe85618185..a1c4defc9f19 100644
--- a/extensions/venkman/resources/content/outliner-utils.js
+++ b/extensions/venkman/resources/content/outliner-utils.js
@@ -1064,6 +1064,12 @@ function tov_isctrempt (index)
     return !row || !row.childData;
 }
 
+TreeOView.prototype.isSeparator =
+function tov_isseparator (index)
+{
+    return false;
+}
+
 TreeOView.prototype.getParentIndex =
 function tov_getpi (index)
 {
diff --git a/extensions/venkman/resources/content/tree-utils.js b/extensions/venkman/resources/content/tree-utils.js
index 36fe85618185..a1c4defc9f19 100644
--- a/extensions/venkman/resources/content/tree-utils.js
+++ b/extensions/venkman/resources/content/tree-utils.js
@@ -1064,6 +1064,12 @@ function tov_isctrempt (index)
     return !row || !row.childData;
 }
 
+TreeOView.prototype.isSeparator =
+function tov_isseparator (index)
+{
+    return false;
+}
+
 TreeOView.prototype.getParentIndex =
 function tov_getpi (index)
 {
diff --git a/extensions/venkman/resources/content/venkman-debugger.js b/extensions/venkman/resources/content/venkman-debugger.js
index 94b20f307114..27d9192e88e0 100644
--- a/extensions/venkman/resources/content/venkman-debugger.js
+++ b/extensions/venkman/resources/content/venkman-debugger.js
@@ -596,7 +596,7 @@ function XXXsetSourceFunctionMarks (url)
     if (!source || !scriptArray)
     {
         dd ("Can't set function marks for " + url);
-        return false;
+        return;
     }
     
     for (var i = 0; i < scriptArray.length; ++i)
@@ -726,7 +726,7 @@ function disableBreakpointByNumber (number)
     if (!bpr)
     {
         display (getMsg(MSN_ERR_BP_NOINDEX, number, MT_ERROR));
-        return 0;
+        return;
     }
 
     bpr.enabled = false;
diff --git a/extensions/venkman/resources/content/venkman-handlers.js b/extensions/venkman/resources/content/venkman-handlers.js
index c6c87b935e18..55f8dcaae1b0 100644
--- a/extensions/venkman/resources/content/venkman-handlers.js
+++ b/extensions/venkman/resources/content/venkman-handlers.js
@@ -207,6 +207,8 @@ function con_icommand (e)
 console.onInputBreak =
 function cli_ibreak(e)
 {    
+    var i;
+    
     if (!e.inputData)
     {  /* if no input data, just list the breakpoints */
         var bplist = console.breakpoints.childData;
@@ -218,7 +220,7 @@ function cli_ibreak(e)
         }
         
         display (getMsg(MSN_BP_HEADER, bplist.length));
-        for (var i = 0; i < bplist.length; ++i)
+        for (i = 0; i < bplist.length; ++i)
         {
             var bpr = bplist[i];
             display (getMsg(MSN_BP_LINE, [i, bpr.fileName, bpr.line,
@@ -241,7 +243,7 @@ function cli_ibreak(e)
         return false;
     }
     
-    for (var i in matchingFiles)
+    for (i in matchingFiles)
         setBreakpoint (matchingFiles[i], ary[2]);
     
     return true;
@@ -292,7 +294,7 @@ function cli_icommands (e)
     if (!console.frames)
     {
         display (MSG_ERR_NO_STACK, MT_ERROR);
-        return false;
+        return;
     }
     cont();
 }
diff --git a/extensions/venkman/resources/content/venkman-outliners.js b/extensions/venkman/resources/content/venkman-outliners.js
index e5bece42d69c..76a4c457c945 100644
--- a/extensions/venkman/resources/content/venkman-outliners.js
+++ b/extensions/venkman/resources/content/venkman-outliners.js
@@ -1113,7 +1113,7 @@ console.stackView.getCellProperties =
 function sv_cellprops (index, colID, properties)
 {
     if (colID != "stack-col-0")
-        return;
+        return null;
     
     var row = this.childData.locateChildByVisualRow(index);
     if (row)
@@ -1136,7 +1136,7 @@ console.projectView.getCellProperties =
 function pv_cellprops (index, colID, properties)
 {
     if (colID != "project-col-0")
-        return;
+        return null;
     
     var row = this.childData.locateChildByVisualRow(index);
     if (row)
diff --git a/extensions/venkman/resources/content/venkman-trees.js b/extensions/venkman/resources/content/venkman-trees.js
index e5bece42d69c..76a4c457c945 100644
--- a/extensions/venkman/resources/content/venkman-trees.js
+++ b/extensions/venkman/resources/content/venkman-trees.js
@@ -1113,7 +1113,7 @@ console.stackView.getCellProperties =
 function sv_cellprops (index, colID, properties)
 {
     if (colID != "stack-col-0")
-        return;
+        return null;
     
     var row = this.childData.locateChildByVisualRow(index);
     if (row)
@@ -1136,7 +1136,7 @@ console.projectView.getCellProperties =
 function pv_cellprops (index, colID, properties)
 {
     if (colID != "project-col-0")
-        return;
+        return null;
     
     var row = this.childData.locateChildByVisualRow(index);
     if (row)