зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1529274 - Remove debugging code for bug 1153929 r=JuniorHsu
The code was added to diagnose an issue that was likely due to heap corruption. The vtable of the objects was sometimes 0. More details in bug 1153929. That crash doesn't reproduce anymore so it should be OK to remove. Differential Revision: https://phabricator.services.mozilla.com/D20561 --HG-- extra : moz-landing-system : lando
This commit is contained in:
Родитель
d820bcd635
Коммит
cee418d221
|
@ -445,12 +445,6 @@ nsresult nsHttpTransaction::Init(
|
|||
nsIOService::gDefaultSegmentCount);
|
||||
if (NS_FAILED(rv)) return rv;
|
||||
|
||||
#ifdef WIN32 // bug 1153929
|
||||
MOZ_DIAGNOSTIC_ASSERT(mPipeOut);
|
||||
uint32_t *vtable = (uint32_t *)mPipeOut.get();
|
||||
MOZ_DIAGNOSTIC_ASSERT(*vtable != 0);
|
||||
#endif // WIN32
|
||||
|
||||
nsCOMPtr<nsIAsyncInputStream> tmp(mPipeIn);
|
||||
tmp.forget(responseBody);
|
||||
return NS_OK;
|
||||
|
@ -932,12 +926,6 @@ nsresult nsHttpTransaction::WriteSegments(nsAHttpSegmentWriter *writer,
|
|||
|
||||
mWriter = writer;
|
||||
|
||||
#ifdef WIN32 // bug 1153929
|
||||
MOZ_DIAGNOSTIC_ASSERT(mPipeOut);
|
||||
uint32_t *vtable = (uint32_t *)mPipeOut.get();
|
||||
MOZ_DIAGNOSTIC_ASSERT(*vtable != 0);
|
||||
#endif // WIN32
|
||||
|
||||
if (!mPipeOut) {
|
||||
return NS_ERROR_UNEXPECTED;
|
||||
}
|
||||
|
@ -1207,13 +1195,6 @@ void nsHttpTransaction::Close(nsresult reason) {
|
|||
|
||||
// closing this pipe triggers the channel's OnStopRequest method.
|
||||
mPipeOut->CloseWithStatus(reason);
|
||||
|
||||
#ifdef WIN32 // bug 1153929
|
||||
MOZ_DIAGNOSTIC_ASSERT(mPipeOut);
|
||||
uint32_t *vtable = (uint32_t *)mPipeOut.get();
|
||||
MOZ_DIAGNOSTIC_ASSERT(*vtable != 0);
|
||||
mPipeOut = nullptr; // just in case
|
||||
#endif // WIN32
|
||||
}
|
||||
|
||||
nsHttpConnectionInfo *nsHttpTransaction::ConnectionInfo() {
|
||||
|
|
Загрузка…
Ссылка в новой задаче