Bug 1444630 - Don't update dictionary after calling UninitSpellChecker. r=masayuki

When calling UninitSpellChecker during calling UpdateDictionary, this crash occurs. Since Thunderbird calls UninitSpellChecker by [Recheck Text] button, this only occurs on Thunderbird. After calling UninitSpellChecker, we should not update dictionary. MozReview-Commit-ID: K4SPJ5FDo8n --HG-- extra : rebase_source : d760c6472f56cef520c399e8c1f20536c3a22e36
2018-03-20 14:27:06 +09:00 · 2018-03-20 14:27:06 +09:00 · d0832ccf7e
--- a/editor/libeditor/crashtests/1444630.html
+++ b/editor/libeditor/crashtests/1444630.html
@ -0,0 +1,28 @@
+<!DOCTYPE HTML>
+<html class="reftest-wait">
+<head>
+<script type="text/javascript">
+function load()
+{
+  let textarea = document.getElementById("editor");
+  textarea.focus();
+
+  SpecialPowers.Cu.import(
+    "chrome://reftest/content/AsyncSpellCheckTestHelper.jsm")
+  .onSpellCheck(textarea, () => {
+    let isc = SpecialPowers.wrap(textarea).editor.getInlineSpellChecker(false);
+    let sc = isc.spellChecker;
+
+    textarea.setAttribute("lang", "en-US");
+    sc.UpdateCurrentDictionary(() => {
+      document.documentElement.classList.remove("reftest-wait");
+    });
+    sc.UninitSpellChecker();
+  });
+}
+</script>
+</head>
+<body onload="load()">
+<textarea id="editor" spellchecker="true">ABC</textarea>
+</body>
+</html>
--- a/editor/libeditor/crashtests/crashtests.list
+++ b/editor/libeditor/crashtests/crashtests.list
@ -98,4 +98,5 @@ load 1414581.html
 load 1415231.html
 load 1425091.html
 load 1443664.html
+skip-if(Android) needs-focus load 1444630.html
 load 1446451.html
--- a/editor/spellchecker/EditorSpellCheck.cpp
+++ b/editor/spellchecker/EditorSpellCheck.cpp
@ -698,6 +698,7 @@ EditorSpellCheck::UninitSpellChecker()
  DeleteSuggestedWordList();
  mDictionaryList.Clear();
  mDictionaryIndex = 0;
+  mDictionaryFetcherGroup++;
  mSpellChecker = nullptr;
  return NS_OK;
 }