Bug 1601034 - Only update the conduit in replaceTrack() if the track source changed between camera and non-camera. r=bwc

Differential Revision: https://phabricator.services.mozilla.com/D56620

--HG--
extra : moz-landing-system : lando

media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp

@@ -1929,13 +1929,21 @@ PeerConnectionImpl::ReplaceTrackNoRenegotiation(TransceiverImpl& aTransceiver,
     PrincipalChanged(aWithTrack);
   }
 
-  // We update the media pipelines here so we can apply different codec
+  if (aTransceiver.IsVideo()) {
-  // settings for different sources (e.g. screensharing as opposed to camera.)
+    // We update the media pipelines here so we can apply different codec
-  // TODO: We should probably only do this if the source has in fact changed.
+    // settings for different sources (e.g. screensharing as opposed to camera.)
-
+    MediaSourceEnum oldSource = oldSendTrack
-  if (NS_FAILED((rv = mMedia->UpdateMediaPipelines()))) {
+                                    ? oldSendTrack->GetSource().GetMediaSource()
-    CSFLogError(LOGTAG, "Error Updating MediaPipelines");
+                                    : MediaSourceEnum::Camera;
-    return rv;
+    MediaSourceEnum newSource = aWithTrack
+                                    ? aWithTrack->GetSource().GetMediaSource()
+                                    : MediaSourceEnum::Camera;
+    if (oldSource != newSource) {
+      if (NS_WARN_IF(NS_FAILED(rv = aTransceiver.UpdateConduit()))) {
+        CSFLogError(LOGTAG, "Error Updating VideoConduit");
+        return rv;
+      }
+    }
   }
 
   return NS_OK;