Bug 1452114 part 1 - Fix GCRuntime::tryNewTenuredThing to report OOM on helper threads as well. r=jonco

--HG--
extra : rebase_source : cb34d5741d697c3fb5cb6dbbdd4f28cb50e3d231

js/src/gc/Allocator.cpp

@@ -244,15 +244,17 @@ GCRuntime::tryNewTenuredThing(JSContext* cx, AllocKind kind, size_t thingSize)
         // chunks available it may also allocate new memory directly.
         t = reinterpret_cast<T*>(refillFreeListFromAnyThread(cx, kind));
 
-        if (MOZ_UNLIKELY(!t && allowGC && !cx->helperThread())) {
+        if (MOZ_UNLIKELY(!t && allowGC)) {
-            // We have no memory available for a new chunk; perform an
+            if (!cx->helperThread()) {
-            // all-compartments, non-incremental, shrinking GC and wait for
+                // We have no memory available for a new chunk; perform an
-            // sweeping to finish.
+                // all-compartments, non-incremental, shrinking GC and wait for
-            JS::PrepareForFullGC(cx);
+                // sweeping to finish.
-            cx->runtime()->gc.gc(GC_SHRINK, JS::gcreason::LAST_DITCH);
+                JS::PrepareForFullGC(cx);
-            cx->runtime()->gc.waitBackgroundSweepOrAllocEnd();
+                cx->runtime()->gc.gc(GC_SHRINK, JS::gcreason::LAST_DITCH);
+                cx->runtime()->gc.waitBackgroundSweepOrAllocEnd();
 
-            t = tryNewTenuredThing<T, NoGC>(cx, kind, thingSize);
+                t = tryNewTenuredThing<T, NoGC>(cx, kind, thingSize);
+            }
             if (!t)
                 ReportOutOfMemory(cx);
         }