Bug 1776895 - [6/6] Add logging for fullscreen entry/exit r=cmartin

Add logging for fullscreen position-state saving and restoration.

Differential Revision: https://phabricator.services.mozilla.com/D153411

widget/nsBaseWidget.cpp

@@ -20,6 +20,7 @@
 #include "mozilla/Attributes.h"
 #include "mozilla/GlobalKeyListener.h"
 #include "mozilla/IMEStateManager.h"
+#include "mozilla/Logging.h"
 #include "mozilla/MouseEvents.h"
 #include "mozilla/NativeKeyBindingsType.h"
 #include "mozilla/Preferences.h"
@@ -86,6 +87,8 @@
 #include "nsView.h"
 #include "nsViewManager.h"
 
+static mozilla::LazyLogModule sBaseWidgetLog("BaseWidget");
+
 #ifdef DEBUG
 #  include "nsIObserver.h"
 
@@ -717,6 +720,10 @@ void nsBaseWidget::PerformFullscreenTransition(FullscreenTransitionStage aStage,
 //
 //-------------------------------------------------------------------------
 void nsBaseWidget::InfallibleMakeFullScreen(bool aFullScreen) {
+#define MOZ_FORMAT_RECT(fmtstr) "[" fmtstr "," fmtstr " " fmtstr "x" fmtstr "]"
+#define MOZ_SPLAT_RECT(rect) \
+  (rect).X(), (rect).Y(), (rect).Width(), (rect).Height()
+
   // Windows which can be made fullscreen are exactly those which are located on
   // the desktop, rather than being a child of some other window.
   MOZ_DIAGNOSTIC_ASSERT(BoundsUseDesktopPixels(),
@@ -758,6 +765,9 @@ void nsBaseWidget::InfallibleMakeFullScreen(bool aFullScreen) {
       return;
     }
 
+    MOZ_LOG(sBaseWidgetLog, LogLevel::Warning,
+            (("window was not resized within InfallibleMakeFullScreen()")));
+
     // Hide chrome and "resize" the window to its current size.
     auto rect = GetBounds();
     adjustOSChrome();
@@ -772,6 +782,21 @@ void nsBaseWidget::InfallibleMakeFullScreen(bool aFullScreen) {
                   
     adjustOSChrome();
     Resize(rect.X(), rect.Y(), rect.Width(), rect.Height(), true);
+
+    {
+      gfx::RectTyped<DesktopPixel, float> rectAsFloat{rect};
+      auto postResizeRect = GetScreenBounds();
+      auto postResizeRectScaled = postResizeRect / GetDesktopToDeviceScale();
+      MOZ_LOG(sBaseWidgetLog, LogLevel::Verbose,
+              ("resize target: " MOZ_FORMAT_RECT("%f"),
+               MOZ_SPLAT_RECT(rectAsFloat)));
+      MOZ_LOG(sBaseWidgetLog, LogLevel::Verbose,
+              ("resize effect (raw): " MOZ_FORMAT_RECT("%d"),
+               MOZ_SPLAT_RECT(postResizeRect)));
+      MOZ_LOG(sBaseWidgetLog, LogLevel::Verbose,
+              ("resize effect (DPI): " MOZ_FORMAT_RECT("%f"),
+               MOZ_SPLAT_RECT(postResizeRectScaled)));
+    }
   };
 
   if (aFullScreen) {
@@ -790,6 +815,14 @@ void nsBaseWidget::InfallibleMakeFullScreen(bool aFullScreen) {
     const auto screenRect = screen->GetRectDisplayPix();
     mSavedBounds->screenRect = screenRect;
     doReposition(screenRect);
+
+    MOZ_LOG(sBaseWidgetLog, LogLevel::Debug,
+            ("window: " MOZ_FORMAT_RECT("%f"),
+             MOZ_SPLAT_RECT(mSavedBounds->windowRect)));
+    MOZ_LOG(sBaseWidgetLog, LogLevel::Debug,
+            ("screen: " MOZ_FORMAT_RECT("%d"),
+             MOZ_SPLAT_RECT(mSavedBounds->screenRect)));
+
   } else {
     if (!mSavedBounds) {
       // This should never happen, at present, since we don't make windows
@@ -808,6 +841,10 @@ void nsBaseWidget::InfallibleMakeFullScreen(bool aFullScreen) {
     const DesktopRect currentWinRect =
         GetScreenBounds() / GetDesktopToDeviceScale();
 
+    MOZ_LOG(sBaseWidgetLog, LogLevel::Debug,
+            ("currentWinRect: " MOZ_FORMAT_RECT("%f"),
+             MOZ_SPLAT_RECT(currentWinRect)));
+
     // Optimization: if where we are is where we were, then where we originally
     // came from is where we're going to go.
     if (currentWinRect == DesktopRect(mSavedBounds->screenRect)) {
@@ -861,8 +898,14 @@ void nsBaseWidget::InfallibleMakeFullScreen(bool aFullScreen) {
     const float nw = remap({0, tw}, {0, sw}, pw);
     const float nh = remap({0, th}, {0, sh}, ph);
 
+    MOZ_LOG(sBaseWidgetLog, LogLevel::Debug,
+            ("final size: " MOZ_FORMAT_RECT("%lf"), nx, ny, nw, nh));
+
     doReposition(DesktopRect{nx, ny, nw, nh});
   }
+
+#undef MOZ_SPLAT_RECT
+#undef MOZ_FORMAT_RECT
 }
 
 nsresult nsBaseWidget::MakeFullScreen(bool aFullScreen) {