Bug 1584571: Fix DLL blocklist entries for oly*.dll to use the correct condition; r=mhowell

I also fixed a couple of typos in comments in the python script that didn't
seem to warrant their own bug.

Differential Revision: https://phabricator.services.mozilla.com/D47455

--HG--
extra : moz-landing-system : lando

mozglue/dllservices/WindowsDllBlocklistDefs.in

@@ -221,10 +221,10 @@ ALL_PROCESSES += [
     DllBlocklistEntry("safemon64.dll", ALL_VERSIONS),
 
     # FYunZip and PuddingZip cause crashes, bug 1576728
-    DllBlocklistEntry("oly64.dll", ALL_VERSIONS, condition='NIGHTLY_BUILD'),
-    DllBlocklistEntry("oly.dll", ALL_VERSIONS, condition='NIGHTLY_BUILD'),
-    DllBlocklistEntry("pdzipmenu64.dll", ALL_VERSIONS, condition='NIGHTLY_BUILD'),
-    DllBlocklistEntry("pdzipmenu32.dll", ALL_VERSIONS, condition='NIGHTLY_BUILD'),
+    DllBlocklistEntry("oly64.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
+    DllBlocklistEntry("oly.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
+    DllBlocklistEntry("pdzipmenu64.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
+    DllBlocklistEntry("pdzipmenu32.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
 ]
 
 ALL_PROCESSES_TESTS += [

mozglue/dllservices/gen_dll_blocklist_defs.py

@@ -588,7 +588,7 @@ class LspBlocklistEntry(DllBlocklistEntry):
 
         guids -- Either a string or list of strings containing the GUIDs that
         uniquely identify the LSP. These GUIDs are generated by the developer of
-        the LSP and are registred with WinSock alongside the LSP. We record
+        the LSP and are registered with WinSock alongside the LSP. We record
         this GUID as part of the "Winsock_LSP" annotation in our crash reports.
 
         flags -- iterable containing the flags that should be applicable to
@@ -597,7 +597,7 @@ class LspBlocklistEntry(DllBlocklistEntry):
         Keyword arguments:
 
         condition -- a string containing a C++ preprocessor expression. This
-        condition is writtn as a condition for an #if/#endif block that is
+        condition is written as a condition for an #if/#endif block that is
         generated around the entry during output.
         """