bug=193068

Missing accesskeys in preference dialogs
r=timeless sr=jaggernaut@netscape.com

editor/ui/composer/content/pref-composer.xul

@@ -44,7 +44,7 @@
   <groupbox>
     <caption label="&recentFiles.title;"/>
     <hbox align="center">
-      <label value="&documentsInMenu;"/>
+      <label value="&documentsInMenu;" accesskey="&documentsInMenu.accesskey;" control="recentFiles"/>
       <textbox
         id="recentFiles"
         name="recent string" 

editor/ui/composer/content/pref-editing.xul

@@ -41,7 +41,7 @@
   <script type="application/x-javascript" src="chrome://editor/content/EdDialogCommon.js"/>
 
   <vbox>
-    <label value="&authorName.label;"/>
+    <label value="&authorName.label;" accesskey="&authorName.accesskey;" control="editorAuthor"/>
     <hbox>
       <textbox id="editorAuthor" flex="1"
                prefstring="editor.author"/>
@@ -68,28 +68,32 @@
         <columns><column/><column/></columns>
         <rows>
           <row align="center">
-            <label id="Text" value="&normalText.label;&colon.character;" />
+            <label id="Text" value="&normalText.label;&colon.character;" 
+                   accesskey="&normalText.accesskey;" control="TextButton"/>
             <button id="TextButton" class="color-button" oncommand="GetColorAndUpdate('textCW');">
               <spacer id="textCW" class="color-well"/>
             </button>
             <data id="textData" pref="true" preftype="color" prefstring="editor.text_color" prefattribute="value" wsm_attributes="value"/>
           </row>
           <row align="center">
-            <label id="Link" value="&linkText.label;&colon.character;" />
+            <label id="Link" value="&linkText.label;&colon.character;" 
+                   accesskey="&linkText.accesskey;" control="LinkButton"/>
             <button id="LinkButton" class="color-button" oncommand="GetColorAndUpdate('linkCW');">
               <spacer id="linkCW" class="color-well"/>
             </button>
             <data id="linkData" pref="true" preftype="color" prefstring="editor.link_color" prefattribute="value" wsm_attributes="value"/>
           </row>
           <row align="center">
-            <label id="Active" value="&activeLinkText.label;&colon.character;" />
+            <label id="Active" value="&activeLinkText.label;&colon.character;" 
+                   accesskey="&activeLinkText.accesskey;" control="ActiveLinkButton"/>
             <button id="ActiveLinkButton" class="color-button" oncommand="GetColorAndUpdate('activeCW');">
               <spacer id="activeCW" class="color-well"/>
             </button>
             <data id="aLinkData" pref="true" preftype="color" prefstring="editor.active_link_color" prefattribute="value" wsm_attributes="value"/>
           </row>
           <row align="center">
-            <label id="Visited" value ="&visitedLinkText.label;&colon.character;" />
+            <label id="Visited" value ="&visitedLinkText.label;&colon.character;" 
+                   accesskey="&visitedLinkText.accesskey;" control="VisitedLinkButton"/>
             <button id="VisitedLinkButton" class="color-button" oncommand="GetColorAndUpdate('visitedCW');">
               <spacer id="visitedCW" class="color-well"/>
             </button>
@@ -118,7 +122,7 @@
       <spacer flex="1"/>
     </hbox>
     <spacer class="spacer"/>
-    <label value="&backgroundImage.label;" accesskey="&backgroundImage.accesskey;"/>
+    <label value="&backgroundImage.label;" accesskey="&backgroundImage.accesskey;" control="BackgroundImageInput"/>
     <hbox align="center">
       <textbox id="BackgroundImageInput" oninput="ChangeBackgroundImage();" style="min-width: 23em" flex="1" class="uri-element">
         <observes element="backgroundImageData" attribute="disabled"/>

editor/ui/composer/locale/en-US/pref-composer.dtd

@@ -33,7 +33,9 @@
 <!ENTITY  chooseButton.label        "Choose">
 
 <!ENTITY  recentFiles.title         "Recent Pages Menu">
+<!ENTITY  documentsInMenu.accesskey     "n">
 <!ENTITY  documentsInMenu           "Maximum number of pages listed:">
 
+
 <!ENTITY  cssEditing.label          "Cascading Style Sheets (CSS) Editing">
 <!ENTITY  useCSS.label              "Use CSS styles instead of HTML elements and attributes">

editor/ui/composer/locale/en-US/pref-editing.dtd

@@ -2,7 +2,7 @@
 <!ENTITY  rHeader                   "Defaults for new pages">
 
 <!ENTITY  authorName.label          "Author:">
-<!ENTITY  authorName.accesskey      "a">
+<!ENTITY  authorName.accesskey      "A">
 <!ENTITY  pageColorHeader           "Default Page Appearance">
 
 <!ENTITY defaultColorsRadio.label   "Reader's default colors (Don't set colors in page)">
@@ -11,14 +11,18 @@
 <!ENTITY customColors.accesskey     "c">
 
 <!ENTITY normalText.label           "Normal text">
+<!ENTITY normalText.accesskey       "N">
 <!ENTITY linkText.label             "Link text">
+<!ENTITY linkText.accesskey         "L">
 <!ENTITY activeLinkText.label       "Active link text">
+<!ENTITY activeLinkText.accesskey   "t">
 <!ENTITY visitedLinkText.label      "Visited link text">
+<!ENTITY visitedLinkText.accesskey  "V">
 <!ENTITY background.label           "Background:">
 <!ENTITY colon.character            ":">
 
 <!ENTITY backgroundImage.label      "Background image:">
-<!ENTITY backgroundImage.accesskey  "g">
+<!ENTITY backgroundImage.accesskey  "B">
 <!ENTITY chooseFile.label           "Choose File...">
 <!ENTITY chooseFile.accesskey       "o">
 

extensions/content-packs/resources/content/pref-contentpacks.xul

@@ -239,8 +239,8 @@
     </vbox>
     <vbox>
     <button id="downloadLanguagePacks" 
-            label="&downloadContentPacks.label;" 
-            accesskey="&downloadContentPacks.accesskey;" 
+            label="&downloadLanguagePacks.label;" 
+            accesskey="&downloadLanguagePacks.accesskey;" 
             oncommand="DownloadRegionPacks()"/>
     </vbox>
   </hbox>

extensions/content-packs/resources/locale/en-US/pref-contentpacks.dtd

@@ -5,8 +5,10 @@
 <!ENTITY restartOnLangChange.label      "Changes to content or language packs take effect when you restart &brandShortName;.">
 <!ENTITY installedContentPacks.label    "Installed content packs:">
 <!ENTITY installedLanguagePacks.label   "Installed language packs:">
-<!ENTITY downloadContentPacks.accesskey "D">
 <!ENTITY downloadContentPacks.label     "Download More...">
+<!ENTITY downloadContentPacks.accesskey "w">
+<!ENTITY downloadLanguagePacks.label    "Download More...">
+<!ENTITY downloadLanguagePacks.accesskey "D">
 <!ENTITY update.label                   "(needs update)">
 <!ENTITY uninstallContentPack.accesskey "u">
 <!ENTITY uninstallContentPack.label     "Uninstall">

extensions/cookie/resources/content/pref-popups.xul

@@ -154,14 +154,16 @@
             <radio value="false" label="&popupAllow.label;" 
                    oncommand="setButtons()"/>
             <spacer flex="1"/>
-            <button id="exceptionsAllow" label="&popupView.label;"
+            <button id="exceptionsAllow" label="&popupViewAllow.label;"
+                    accesskey="&popupViewAllow.accesskey;"
                     oncommand="viewPopups();"/>
           </hbox>        
           <hbox>
             <radio value="true" label="&popupBlock.label;"
                    oncommand="setButtons()"/>
             <spacer flex="1"/>
-            <button id="exceptionsBlock" label="&popupView.label;"
+            <button id="exceptionsBlock" label="&popupViewBlock.label;"
+                    accesskey="&popupViewBlock.accesskey;"
                     oncommand="viewPopups();"/>
           </hbox>
         </vbox>

extensions/cookie/resources/locale/en-US/pref-popups.dtd

@@ -9,7 +9,10 @@
 <!ENTITY popupBlock.label               "Suppress popups">
 <!ENTITY popupBlock.accesskey           "S">
 
-<!ENTITY popupView.label                "Exceptions...">
+<!ENTITY popupViewAllow.label           "Exceptions...">
+<!ENTITY popupViewAllow.accesskey       "x">
+<!ENTITY popupViewBlock.label           "Exceptions...">
+<!ENTITY popupViewBlock.accesskey       "c">
 
 <!ENTITY whenBlock.description          "When a popup window has been suppressed:">
 <!ENTITY playSound.label                "Play a sound:">

mailnews/base/prefs/resources/content/pref-notifications.xul

@@ -67,9 +67,10 @@ Contributor(s):
       <textbox flex="1" oninput="onCustomWavInput()" id="mailnewsSoundFileUrl" preftype="string"
            prefstring="mail.biff.play_sound.url"/>
       <hbox autostretch="never">
-        <button id="browse" label="&browse.label;" filepickertitle="&browse.title;" oncommand="Browse()"/>
-        <button id="preview" label="&preview.label;" 
-              oncommand="PreviewSound()"/>
+        <button id="browse" label="&browse.label;" filepickertitle="&browse.title;"
+                accesskey="&browse.accesskey;" oncommand="Browse()"/>
+        <button id="preview" label="&preview.label;"
+                accesskey="&preview.accesskey;" oncommand="PreviewSound()"/>
       </hbox>
     </hbox>
   </groupbox>

mailnews/base/prefs/resources/content/pref-receipts.xul

@@ -83,7 +83,8 @@
             <columns><column/><column/></columns>
             <rows>
               <row align="center">
-                <label id="notInToCcLabel" accesskey="&notInToCc.accesskey;" control="notInToCcPref">&notInToCc.label;</label>
+                <label id="notInToCcLabel" accesskey="&notInToCc.accesskey;" 
+                       control="notInToCcPref" value="&notInToCc.label;"/>
                 <menulist id="notInToCcPref" prefstring="mail.mdn.report.not_in_to_cc">
                   <menupopup>
                     <menuitem value="0" label="&neverSend.label;"/>
@@ -93,7 +94,8 @@
                 </menulist>
               </row>
               <row align="center">
-                <label id="outsideDomainLabel" accesskey="&outsideDomain.accesskey;" control="outsideDomainPref">&outsideDomain.label;</label>
+                <label id="outsideDomainLabel" accesskey="&outsideDomain.accesskey;"
+                       control="outsideDomainPref" value="&outsideDomain.label;"/>
                 <menulist id="outsideDomainPref" prefstring="mail.mdn.report.outside_domain">
                   <menupopup>
                     <menuitem value="0" label="&neverSend.label;"/>
@@ -103,7 +105,8 @@
                 </menulist>
               </row>
               <row align="center">
-                <label id="otherCasesLabel" accesskey="&otherCases.accesskey;" control="otherCasesPref">&otherCases.label;</label>
+                <label id="otherCasesLabel" accesskey="&otherCases.accesskey;" control="otherCasesPref"
+                       value="&otherCases.label;"/>
                 <menulist id="otherCasesPref" prefstring="mail.mdn.report.other">
                   <menupopup>
                     <menuitem value="0" label="&neverSend.label;"/>

mailnews/base/prefs/resources/locale/en-US/pref-notifications.dtd

@@ -25,6 +25,7 @@ Rights Reserved.
 <!ENTITY showAnimatedAlert.label          "Show an alert">
 <!ENTITY showAnimatedAlert.accesskey      "S">
 <!ENTITY preview.label                    "Preview">
+<!ENTITY preview.accesskey                "v">
 <!ENTITY systemsound.label                "System New Mail Sound">
 <!ENTITY customsound.label                "Custom wav file">
 <!ENTITY browse.label                     "Browse...">

security/manager/pki/resources/content/pref-certs.xul

@@ -64,6 +64,7 @@
       <button label="&managecerts.button;"
               oncommand="openCertManager();" 
               id="openCertManagerButton"
+              accesskey="&managecerts.accesskey;"
               prefstring="security.disable_button.openCertManager"/>
     </hbox>
   </groupbox>
@@ -76,6 +77,7 @@
       <button label="&managedevices.button;"
               oncommand="openDeviceManager();"
               id="openDeviceManagerButton"
+              accesskey="&managedevices.accesskey;"
               prefstring="security.disable_button.openDeviceManager"/>
     </hbox>
   </groupbox>

security/manager/pki/resources/content/pref-masterpass.xul

@@ -55,6 +55,7 @@
       <button label="&changepassword.button;"
               oncommand="ChangePW();"
               id="changePasswordButton"
+              accesskey="&changepassword.accesskey;"
               prefstring="security.disable_button.changePassword"/>
     </hbox>
   </groupbox>
@@ -99,6 +100,7 @@
       <button label="&resetpassword.button;"
               oncommand="ResetPW();"
               id="resetPasswordButton"
+              accesskey="&resetpassword.accesskey;"
               prefstring="security.disable_button.resetPassword"/>
     </hbox>
   </groupbox>

security/manager/pki/resources/content/pref-ssl.xul

@@ -60,6 +60,7 @@
 
     <vbox halign="right">
       <button label="&edit.sslciphers;"
+              accesskey="&edit.sslciphers.accesskey;"
               oncommand="window.openDialog('chrome://pippki/content/pref-ciphers.xul', '',
                              'modal=yes,resizable,chrome');"
               id="editSSLCiphersButton"

security/manager/pki/resources/content/pref-validation.xul

@@ -50,6 +50,7 @@
       <button label="&validation.managecrls.button;"
               oncommand="openCrlManager();"
               id="managecrlbutton"
+              accesskey="&validation.managecrls.accesskey;"
               prefstring="security.OCSP.disable_button.managecrl"/>
     </hbox>
   </groupbox>
@@ -72,14 +73,14 @@
           
           <rows>
             <row align="center">
-              <label value="&signingCA.label;" control="signingCA"/>
+              <label value="&signingCA.label;" accesskey="&signingCA.accesskey;" control="signingCA"/>
               <menulist id="signingCA" preftype="string" prefstring="security.OCSP.signingCA"
                         flex="1" oncommand="changeURL()">
                 <menupopup/>
               </menulist>
             </row>
             <row align="center">
-              <label value="&serviceURL.label;" control="serviceURL"/>
+              <label value="&serviceURL.label;" accesskey="&serviceURL.accesskey;" control="serviceURL"/>
               <textbox id="serviceURL" prefstring="security.OCSP.URL"/>
             </row>
          </rows>

security/manager/pki/resources/locale/en-US/pref-masterpass.dtd

@@ -32,7 +32,9 @@
 <!ENTITY  changepassword.label    "Change Master Password">
 <!ENTITY  changepassword.text     "Your master password protects sensitive information such as web passwords and certificates.">
 <!ENTITY  changepassword.button   "Change Password...">
+<!ENTITY  changepassword.accesskey  "C">
 
 <!ENTITY  resetpassword.label    "Reset Master Password">
 <!ENTITY  resetpassword.text     "If you reset your master password, all of your stored Web and e-mail passwords, form data, personal certificates, and private keys will be lost.">
 <!ENTITY  resetpassword.button   "Reset Password">
+<!ENTITY  resetpassword.accesskey   "R">

security/manager/pki/resources/locale/en-US/pref-security.dtd

@@ -30,9 +30,11 @@
 <!ENTITY  managecerts.label      "Manage Certificates">
 <!ENTITY  managecerts.text       "Use the Certificate Manager to manage your personal certificates, as well as those of other people and certificate authorities.">
 <!ENTITY  managecerts.button     "Manage Certificates...">
+<!ENTITY  managecerts.accesskey  "M">
 <!ENTITY  managedevices.label    "Manage Security Devices">
 <!ENTITY  managedevices.text     "Use this button to manage your security devices, such as smart cards.">
 <!ENTITY  managedevices.button   "Manage Security Devices...">
+<!ENTITY  managedevices.accesskey   "S">
 
 <!ENTITY  ssl.label              "SSL">
 

security/manager/pki/resources/locale/en-US/pref-ssl.dtd

@@ -31,6 +31,7 @@
 <!ENTITY enable.tls "Enable TLS">
 
 <!ENTITY edit.sslciphers "Edit Ciphers...">
+<!ENTITY edit.sslciphers.accesskey "E">
 
 <!ENTITY warn.description "&brandShortName; can alert you to the security status of the web page you are viewing. Set &brandShortName; to show a warning and ask permission before:">
 <!ENTITY warn.enteringsecure "Loading a page that supports encryption">

security/manager/pki/resources/locale/en-US/pref-validation.dtd

@@ -25,6 +25,7 @@
 <!ENTITY  validation.crl.label      "CRL">
 <!ENTITY  validation.crl.description "Use the CRL Manager to manage the Certificate Revocation Lists (CRL) that are stored in your certificate database.">
 <!ENTITY  validation.managecrls.button      "Manage CRLs...">
+<!ENTITY  validation.managecrls.accesskey   "M">
 <!ENTITY  validation.crlmanager.label       "Manage CRLs">
 <!ENTITY  validation.crlname.label          "Name">
 <!ENTITY  validation.crllastupdate.label    "Last Update">
@@ -61,4 +62,6 @@
 <!ENTITY certOCSP.label "Use OCSP to validate only certificates that specify an OCSP service URL">
 <!ENTITY proxyOCSP.label "Use OCSP to validate all certificates using this URL and signer:">
 <!ENTITY serviceURL.label "Service URL:">
+<!ENTITY serviceURL.accesskey "S">
 <!ENTITY signingCA.label "Response Signer:">
+<!ENTITY signingCA.accesskey "R">

xpfe/components/prefwindow/resources/content/pref-debug.xul

@@ -86,10 +86,11 @@
         
         <rows>
           <row align="center">
-            <label value="&acceleratorKey.label;" for="acceleratorKeyValue"/>
+            <label value="&acceleratorKey.label;" for="acceleratorKeyValue"
+                   accesskey="&acceleratorKey.accesskey;" control="acceleratorKeyValue"/>
             <textbox id="acceleratorKeyValue"  preftype="int"
               prefstring="ui.key.accelKey" size="5"/>
-            <label value="&menuAccessKey.label;" control="menuAccessKeyValue"/>
+            <label value="&menuAccessKey.label;" accesskey="&menuAccessKey.accesskey;" control="menuAccessKeyValue"/>
             <textbox id="menuAccessKeyValue"  preftype="int"
               prefstring="ui.key.menuAccessKey" size="5"/>
           </row>

xpfe/components/prefwindow/resources/content/pref-popups.xul

@@ -154,14 +154,16 @@
             <radio value="false" label="&popupAllow.label;" 
                    oncommand="setButtons()"/>
             <spacer flex="1"/>
-            <button id="exceptionsAllow" label="&popupView.label;"
+            <button id="exceptionsAllow" label="&popupViewAllow.label;"
+                    accesskey="&popupViewAllow.accesskey;"
                     oncommand="viewPopups();"/>
           </hbox>        
           <hbox>
             <radio value="true" label="&popupBlock.label;"
                    oncommand="setButtons()"/>
             <spacer flex="1"/>
-            <button id="exceptionsBlock" label="&popupView.label;"
+            <button id="exceptionsBlock" label="&popupViewBlock.label;"
+                    accesskey="&popupViewBlock.accesskey;"
                     oncommand="viewPopups();"/>
           </hbox>
         </vbox>

xpfe/components/prefwindow/resources/content/pref-smart_browsing.xul

@@ -75,7 +75,8 @@
                   accesskey="&autoCompleteEnabled.accesskey;"
                   prefstring="browser.urlbar.autocomplete.enabled"
                   oncommand="toggleAutoCompleteAdvancedButton()" flex="1"/>
-      <button label="&autoCompleteAdvanced.label;" oncommand="showACAdvanced()" id="autoCompleteAdvancedButton"/>
+      <button label="&autoCompleteAdvanced.label;" oncommand="showACAdvanced()" id="autoCompleteAdvancedButton"
+              accesskey="&autoCompleteAdvanced.accesskey;"/>
       <data id="browserUrlbarAutoFill" preftype="bool" prefattribute="value"
             prefstring="browser.urlbar.autoFill"/>
       <data id="browserUrlbarShowPopup" preftype="bool" prefattribute="value"

xpfe/components/prefwindow/resources/content/pref-themes.xul

@@ -83,7 +83,8 @@
       <label id="description" flex="1"/>
     </vbox>
     <vbox>
-      <button id="uninstallSkin" label="&uninstallSkin.label;" oncommand="uninstallSkin();"/>
+      <button id="uninstallSkin" label="&uninstallSkin.label;" oncommand="uninstallSkin();"
+              accesskey="&uninstallSkin.accesskey;"/>
     </vbox>
   </hbox>
   <separator/>

xpfe/components/prefwindow/resources/locale/en-US/pref-debug.dtd

@@ -22,4 +22,6 @@
 <!ENTITY accelerators.label  "Keyboard accelerators">
 <!ENTITY acceleratorsBlurb.label  "A value of zero disables a modifier key.">
 <!ENTITY acceleratorKey.label  "Accelerator key:">
+<!ENTITY acceleratorKey.accesskey  "A">
 <!ENTITY menuAccessKey.label   "Menu access key:">
+<!ENTITY menuAccessKey.accesskey   "M">

xpfe/components/prefwindow/resources/locale/en-US/pref-history.dtd

@@ -3,7 +3,7 @@
 <!ENTITY  header3.label             "Browsing History">
 <!ENTITY  historyPages.label        "History is a list of previously visited pages.">
 <!ENTITY  pageHis.label             "Remember visited pages for the last">
-<!ENTITY  pageHis.accesskey         "p">
+<!ENTITY  pageHis.accesskey         "a">
 <!ENTITY  days.label                "days">
 <!ENTITY  clearHistory.label        "Clear History">
 <!ENTITY  clearHistory.accesskey    "r">

xpfe/components/prefwindow/resources/locale/en-US/pref-popups.dtd

@@ -9,7 +9,10 @@
 <!ENTITY popupBlock.label               "Suppress popups">
 <!ENTITY popupBlock.accesskey           "S">
 
-<!ENTITY popupView.label                "Exceptions...">
+<!ENTITY popupViewAllow.label           "Exceptions...">
+<!ENTITY popupViewAllow.accesskey       "x">
+<!ENTITY popupViewBlock.label           "Exceptions...">
+<!ENTITY popupViewBlock.accesskey       "c">
 
 <!ENTITY whenBlock.description          "When a popup window has been suppressed:">
 <!ENTITY playSound.label                "Play a sound:">

xpfe/components/prefwindow/resources/locale/en-US/pref-smart_browsing.dtd

@@ -18,6 +18,7 @@
 <!ENTITY  autoCompleteEnabled.accesskey             "l">
 
 <!ENTITY  autoCompleteAdvanced.label             "Advanced...">
+<!ENTITY  autoCompleteAdvanced.accesskey         "A">
 <!ENTITY  autoCompleteAdvanced.title             "Autocomplete Preferences">
 <!ENTITY  autoCompleteAutoFill.label             "Autocomplete best match as you type">
 <!ENTITY  autoCompleteShowPopup.label            "Show list of matching results">

xpfe/components/prefwindow/resources/locale/en-US/pref-themes.dtd

@@ -9,7 +9,7 @@
 <!ENTITY  selectSkin.accesskey    "a">
 
 <!ENTITY  uninstallSkin.label        "Uninstall Theme">
-<!ENTITY  uninstallSkin.accesskey    "u">
+<!ENTITY  uninstallSkin.accesskey    "U">
 
 <!ENTITY  general.label           "General">
 <!ENTITY  preview.label           "Preview Image">