зеркало из https://github.com/mozilla/gecko-dev.git
Bug 783607 - Update code and write tests for <input type='number'> precision fixes. r=jwatt
--HG-- rename : content/html/content/test/forms/test_input_range_rounding.html => content/html/content/test/forms/test_input_number_rounding.html
This commit is contained in:
Mounir Lamouri
Родитель
aa1f1295a6
Коммит
d2724b7012
|
|
@ -5028,8 +5028,6 @@ HTMLInputElement::GetStep() const
|
|||
step = GetDefaultStep();
|
||||
}
|
||||
|
||||
// TODO: This multiplication can lead to inexact results, we should use a
|
||||
// type that supports a better precision than double. Bug 783607.
|
||||
return step * GetStepScaleFactor();
|
||||
}
|
||||
|
||||
|
|
@ -5220,15 +5218,6 @@ HTMLInputElement::HasStepMismatch() const
|
|||
return false;
|
||||
}
|
||||
|
||||
if (mType == NS_FORM_INPUT_DATE) {
|
||||
// The multiplication by the stepScaleFactor for date can easily lead
|
||||
// to precision loss, since in most use cases this value should be
|
||||
// an integer (millisecond precision), we can get rid of the precision
|
||||
// loss by rounding step. This will however lead to erroneous results
|
||||
// when step was intented to have a precision superior to a millisecond.
|
||||
step = step.round();
|
||||
}
|
||||
|
||||
// Value has to be an integral multiple of step.
|
||||
return NS_floorModulo(value - GetStepBase(), step) != 0;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -60,6 +60,7 @@ MOCHITEST_FILES = \
|
|||
submit_invalid_file.sjs \
|
||||
test_input_file_picker.html \
|
||||
test_input_event.html \
|
||||
test_input_number_rounding.html \
|
||||
$(NULL)
|
||||
|
||||
include $(topsrcdir)/config/rules.mk
|
||||
|
|
|
|||
|
|
@ -0,0 +1,116 @@
|
|||
<!DOCTYPE HTML>
|
||||
<html>
|
||||
<!--
|
||||
https://bugzilla.mozilla.org/show_bug.cgi?id=783607
|
||||
-->
|
||||
<head>
|
||||
<title>Test rounding behaviour for <input type='number'></title>
|
||||
<script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
|
||||
<script type="text/javascript" src="/tests/SimpleTest/EventUtils.js"></script>
|
||||
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
|
||||
<meta charset="UTF-8">
|
||||
</head>
|
||||
<body>
|
||||
<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=783607">Mozilla Bug 783607</a>
|
||||
<p id="display"></p>
|
||||
<div id="content">
|
||||
<input id=number type=number value=0 step=0.01 max=1>
|
||||
</div>
|
||||
<pre id="test">
|
||||
<script type="application/javascript">
|
||||
|
||||
/**
|
||||
* Test for Bug 783607.
|
||||
* This test checks that when <input type=number> has fractional step values,
|
||||
* the values that a content author will see in their script will not have
|
||||
* ugly rounding errors.
|
||||
**/
|
||||
SimpleTest.waitForExplicitFinish();
|
||||
SimpleTest.waitForFocus(function() {
|
||||
test();
|
||||
SimpleTest.finish();
|
||||
});
|
||||
|
||||
/**
|
||||
* We can _NOT_ generate these values by looping and simply incrementing a
|
||||
* variable by 0.01 and stringifying it, since we'll end up with strings like
|
||||
* "0.060000000000000005" due to the inability of binary floating point numbers
|
||||
* to accurately represent decimal values.
|
||||
*/
|
||||
var stepVals = [
|
||||
"0", "0.01", "0.02", "0.03", "0.04", "0.05", "0.06", "0.07", "0.08", "0.09",
|
||||
"0.1", "0.11", "0.12", "0.13", "0.14", "0.15", "0.16", "0.17", "0.18", "0.19",
|
||||
"0.2", "0.21", "0.22", "0.23", "0.24", "0.25", "0.26", "0.27", "0.28", "0.29",
|
||||
"0.3", "0.31", "0.32", "0.33", "0.34", "0.35", "0.36", "0.37", "0.38", "0.39",
|
||||
"0.4", "0.41", "0.42", "0.43", "0.44", "0.45", "0.46", "0.47", "0.48", "0.49",
|
||||
"0.5", "0.51", "0.52", "0.53", "0.54", "0.55", "0.56", "0.57", "0.58", "0.59",
|
||||
"0.6", "0.61", "0.62", "0.63", "0.64", "0.65", "0.66", "0.67", "0.68", "0.69",
|
||||
"0.7", "0.71", "0.72", "0.73", "0.74", "0.75", "0.76", "0.77", "0.78", "0.79",
|
||||
"0.8", "0.81", "0.82", "0.83", "0.84", "0.85", "0.86", "0.87", "0.88", "0.89",
|
||||
"0.9", "0.91", "0.92", "0.93", "0.94", "0.95", "0.96", "0.97", "0.98", "0.99",
|
||||
"1"
|
||||
];
|
||||
|
||||
var pgUpDnVals = [
|
||||
"0", "0.1", "0.2", "0.3", "0.4", "0.5", "0.6", "0.7", "0.8", "0.9", "1"
|
||||
];
|
||||
|
||||
function test() {
|
||||
var elem = document.getElementById("number");
|
||||
|
||||
elem.focus();
|
||||
|
||||
/**
|
||||
* TODO:
|
||||
* When <input type='number'> widget will have a widge we should test PAGE_UP,
|
||||
* PAGE_DOWN, UP and DOWN keys. For the moment, there is no widget so those
|
||||
* keys do not have any effect.
|
||||
* The tests using those keys as marked as todo_is() hoping that at least part
|
||||
* of them will fail when the widget will be implemented.
|
||||
*/
|
||||
|
||||
for (var i = 1; i < pgUpDnVals.length; ++i) {
|
||||
synthesizeKey("VK_PAGE_UP", {});
|
||||
todo_is(elem.value, pgUpDnVals[i], "Test VK_PAGE_UP");
|
||||
is(elem.validity.valid, true, "Check element is valid for value " + pgUpDnVals[i]);
|
||||
}
|
||||
|
||||
for (var i = pgUpDnVals.length - 2; i >= 0; --i) {
|
||||
synthesizeKey("VK_PAGE_DOWN", {});
|
||||
// TODO: this condition is there because the todo_is() below would pass otherwise.
|
||||
if (stepVals[i] == 0) { continue; }
|
||||
todo_is(elem.value, pgUpDnVals[i], "Test VK_PAGE_DOWN");
|
||||
is(elem.validity.valid, true, "Check element is valid for value " + pgUpDnVals[i]);
|
||||
}
|
||||
|
||||
for (var i = 1; i < stepVals.length; ++i) {
|
||||
synthesizeKey("VK_UP", {});
|
||||
todo_is(elem.value, stepVals[i], "Test VK_UP");
|
||||
is(elem.validity.valid, true, "Check element is valid for value " + stepVals[i]);
|
||||
}
|
||||
|
||||
for (var i = stepVals.length - 2; i >= 0; --i) {
|
||||
synthesizeKey("VK_DOWN", {});
|
||||
// TODO: this condition is there because the todo_is() below would pass otherwise.
|
||||
if (stepVals[i] == 0) { continue; }
|
||||
todo_is(elem.value, stepVals[i], "Test VK_DOWN");
|
||||
is(elem.validity.valid, true, "Check element is valid for value " + stepVals[i]);
|
||||
}
|
||||
|
||||
for (var i = 1; i < stepVals.length; ++i) {
|
||||
elem.stepUp();
|
||||
is(elem.value, stepVals[i], "Test stepUp()");
|
||||
is(elem.validity.valid, true, "Check element is valid for value " + stepVals[i]);
|
||||
}
|
||||
|
||||
for (var i = stepVals.length - 2; i >= 0; --i) {
|
||||
elem.stepDown();
|
||||
is(elem.value, stepVals[i], "Test stepDown()");
|
||||
is(elem.validity.valid, true, "Check element is valid for value " + stepVals[i]);
|
||||
}
|
||||
}
|
||||
|
||||
</script>
|
||||
</pre>
|
||||
</body>
|
||||
</html>
|
||||
|
|
@ -406,6 +406,13 @@ for (var test of data) {
|
|||
input.value = 2;
|
||||
checkValidity(input, false, apply, {low: 1, high: 3});
|
||||
|
||||
// Rounding issues.
|
||||
input = getFreshElement(test.type);
|
||||
input.min = 0.1;
|
||||
input.step = 0.2;
|
||||
input.value = 0.3;
|
||||
checkValidity(input, true, apply);
|
||||
|
||||
// Check that when the higher value is higher than max, we don't show it.
|
||||
input = getFreshElement(test.type);
|
||||
input.step = '2';
|
||||
|
|
|
|||
Загрузка…
Ссылка в новой задаче