Bug 1835028 - Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8

Differential Revision: https://phabricator.services.mozilla.com/D179906

.stylelintrc.js

@@ -247,7 +247,6 @@ module.exports = {
     {
       files: "browser/components/newtab/**",
       customSyntax: "postcss-scss",
-      defaultSeverity: "warning",
       extends: "stylelint-config-standard-scss",
       rules: {
         "at-rule-disallowed-list": [
@@ -268,32 +267,22 @@ module.exports = {
         ],
         "custom-property-empty-line-before": null,
         "custom-property-pattern": null,
-        "declaration-block-no-duplicate-properties": [
-          true,
-          {
-            severity: "error",
-          },
-        ],
+        "declaration-block-no-duplicate-properties": true,
         "declaration-block-no-redundant-longhand-properties": null,
-        "declaration-no-important": [
+        "declaration-no-important": true,
+        "function-no-unknown": [
           true,
           {
-            severity: "error",
-          },
-        ],
-        "function-url-no-scheme-relative": [
-          true,
-          {
-            severity: "error",
+            ignoreFunctions: ["div"],
           },
         ],
+        "function-url-no-scheme-relative": true,
         indentation: 2,
         "keyframes-name-pattern": null,
         "max-nesting-depth": [
           8,
           {
             ignore: ["blockless-at-rules", "pseudo-classes"],
-            severity: "error",
           },
         ],
         "media-feature-name-no-vendor-prefix": null,
@@ -306,15 +295,9 @@ module.exports = {
           ["margin-left", "margin-right"],
           {
             message: "Use margin-inline instead of %s",
-            severity: "error",
-          },
-        ],
-        "property-no-unknown": [
-          true,
-          {
-            severity: "error",
           },
         ],
+        "property-no-unknown": true,
         "property-no-vendor-prefix": null,
         "scss/dollar-variable-empty-line-before": null,
         "scss/double-slash-comment-empty-line-before": [
@@ -330,7 +313,6 @@ module.exports = {
           "single",
           {
             avoidEscape: true,
-            severity: "error",
           },
         ],
         "value-keyword-case": null,

browser/components/newtab/content-src/components/DiscoveryStreamComponents/CardGrid/_CardGrid.scss

@@ -84,8 +84,10 @@ $col4-header-font-size: 14;
       @media (forced-colors: active) {
         fill: CurrentColor;
       }
+
       fill: var(--newtab-text-primary-color);
     }
+
     @media (forced-colors: active) {
       fill: CurrentColor;
     }

browser/components/newtab/content-src/components/DiscoveryStreamComponents/DSDismiss/_DSDismiss.scss

@@ -29,6 +29,7 @@
       @media (forced-colors: active) {
         fill: CurrentColor;
       }
+
       fill: var(--newtab-text-primary-color);
     }
 

browser/components/newtab/content-src/styles/_theme.scss

@@ -14,7 +14,7 @@ $inner-box-shadow: 0 0 0 1px var(--newtab-inner-box-shadow-color);
 $input-border: 1px solid var(--newtab-border-color);
 $input-border-active: 1px solid var(--newtab-textbox-focus-color);
 $input-error-border: 1px solid var(--newtab-status-error);
-$input-error-boxshadow: textbox-shadow(var(--newtab-status-error));
+$input-error-boxshadow: #{textbox-shadow(var(--newtab-status-error))};
 $shadow-primary: 0 0 0 5px var(--newtab-element-secondary-color);
 $shadow-secondary: 0 1px 4px 0 $grey-90-20;
 $shadow-large: 0 2px 14px 0 $black-20;