Bug 1694662 - Remove Appcache storage pref r=necko-reviewers,kershaw

Differential Revision: https://phabricator.services.mozilla.com/D106461

browser/base/content/test/sanitize/browser.ini

@@ -5,7 +5,6 @@ support-files=
   dummy_page.html
 prefs=
   browser.cache.offline.enable=true
-  browser.cache.offline.storage.enable=true
 
 [browser_purgehistory_clears_sh.js]
 [browser_sanitize-formhistory.js]

modules/libpref/init/StaticPrefList.yaml

@@ -830,11 +830,6 @@
   value: @IS_NOT_EARLY_BETA_OR_EARLIER@
   mirror: always
 
-- name: browser.cache.offline.storage.enable
-  type: bool
-  value: false
-  mirror: always
-
 - name: browser.cache.disk.enable
   type: RelaxedAtomicBool
   value: true

netwerk/test/unit/test_bug650995.js

@@ -169,7 +169,6 @@ function run_test() {
   httpserver.start(-1);
 
   prefService.setBoolPref("browser.cache.offline.enable", false);
-  prefService.setBoolPref("browser.cache.offline.storage.enable", false);
   prefService.setBoolPref("network.http.rcwn.enabled", false);
 
   nextTest();

testing/profiles/web-platform/user.js

@@ -63,7 +63,6 @@ user_pref("widget.disable-dark-scrollbar", true);
 user_pref("nglayout.initialpaint.unsuppress_with_no_background", true);
 user_pref("media.block-autoplay-until-in-foreground", false);
 // Enable AppCache globally for now whilst it's being removed in Bug 1584984
-user_pref("browser.cache.offline.storage.enable", true);
 user_pref("browser.cache.offline.enable", true);
 // Enable blocking access to storage from tracking resources by default.
 // We don't want to run WPT using BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN (5 - aka Dynamic First Party Isolation) yet.

testing/web-platform/meta/html/browsers/offline/appcache/workers/appcache-worker.https.html.ini

@@ -1,5 +1,4 @@
 [appcache-worker.https.html]
-  prefs: [browser.cache.offline.storage.enable:true]
   disabled:
     if verify: fails in verify mode
   expected: TIMEOUT

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_status_checking-manual.html.ini

@@ -1,2 +1,2 @@
 [api_status_checking-manual.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_status_downloading-manual.html.ini

@@ -1,2 +1,2 @@
 [api_status_downloading-manual.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_status_idle.https.html.ini

@@ -1,2 +1,2 @@
 [api_status_idle.https.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_status_obsolete-manual.html.ini

@@ -1,2 +1,2 @@
 [api_status_obsolete-manual.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_status_uncached.https.html.ini

@@ -1,2 +1,2 @@
 [api_status_uncached.https.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_status_updateready-manual.html.ini

@@ -1,2 +1,2 @@
 [api_status_updateready-manual.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_swapcache-manual.html.ini

@@ -1,2 +1,2 @@
 [api_swapcache-manual.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_swapcache_error.https.html.ini

@@ -2,4 +2,4 @@
   disabled:
     if tsan: https://bugzilla.mozilla.org/show_bug.cgi?id=1701693
 
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_update.https.html.ini

@@ -2,4 +2,4 @@
   disabled:
     if tsan: https://bugzilla.mozilla.org/show_bug.cgi?id=1701693
     
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/application-cache-api/api_update_error.https.html.ini

@@ -1,5 +1,5 @@
 [api_update_error.https.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]
   [INVALID_STATE_ERR error test]
     expected: FAIL
 

testing/web-platform/meta/html/browsers/offline/application-cache-api/secure_context.html.ini

@@ -1,2 +1,2 @@
 [secure_context.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/manifest_url_check.https.https.html.ini

@@ -1,2 +1,2 @@
 [manifest_url_check.https.https.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]

testing/web-platform/meta/html/browsers/offline/no-appcache-in-shared-workers-historical.https.html.ini

@@ -1,4 +1,4 @@
 [no-appcache-in-shared-workers-historical.https.html]
-  prefs: [browser.cache.offline.storage.enable:true,browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]
   disabled:
     if (os == "win"): Bug 1581711

testing/web-platform/meta/service-workers/service-worker/appcache-ordering-main.https.html.ini

@@ -1,5 +1,5 @@
 [appcache-ordering-main.https.html]
-  prefs: [browser.cache.offline.enable:true,browser.cache.offline.storage.enable:true]
+  prefs: [browser.cache.offline.enable:true]
   disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1305877
   expected:
     if (e10s and (os == "win")) or ((os == "linux") and (bits == 64)): TIMEOUT

testing/web-platform/meta/service-workers/service-worker/clients-get.https.html.ini

@@ -1,5 +1,5 @@
 [clients-get.https.html]
-  prefs: [browser.cache.offline.storage.enable:true, browser.cache.offline.enable:true]
+  prefs: [browser.cache.offline.enable:true]
   disabled:
     if debug and (os == "mac"): https://bugzilla.mozilla.org/show_bug.cgi?id=1586420
   expected:

testing/web-platform/meta/signed-exchange/appcache/sxg-inner-resp-over-appcache.tentative.https.html.ini

@@ -1,5 +1,4 @@
 [sxg-inner-resp-over-appcache.tentative.https.html]
-  prefs: [browser.cache.offline.storage.enable:true]
   [SignedHTTPExchange inner resp should take precedence to appcache.]
     expected: FAIL
 

testing/web-platform/meta/signed-exchange/appcache/sxg-served-from-appcache.tentative.https.html.ini

@@ -1,5 +1,4 @@
 [sxg-served-from-appcache.tentative.https.html]
-  prefs: [browser.cache.offline.storage.enable:true]
   [SignedHTTPExchange cached in appcache should work.]
     expected: FAIL
 

toolkit/components/backgroundtasks/defaults/backgroundtasks.js

@@ -8,7 +8,6 @@ pref("devtools.console.stdout.chrome", true);
 pref("network.process.enabled", false);
 
 pref("browser.cache.offline.enable", false);
-pref("browser.cache.offline.storage.enable", false);
 pref("browser.cache.disk.enable", false);
 pref("permissions.memory_only", true);
 

toolkit/components/forgetaboutsite/test/unit/test_removeDataFromDomain.js

@@ -526,10 +526,7 @@ var tests = [
 //
 // Due to these prefs being static, setting them doesn't make a difference in time for the test
 // As we are removing AppCache in Bug 1584984 this will just be removed soon.
-if (
-  Services.prefs.getBoolPref("browser.cache.offline.enable") &&
-  Services.prefs.getBoolPref("browser.cache.offline.storage.enable")
-) {
+if (Services.prefs.getBoolPref("browser.cache.offline.enable")) {
   tests.push(test_cache_cleared);
 }