From d42db71402fd6e5321bef23af7e28773c6a120a7 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Thu, 20 Oct 2022 01:55:20 +0000 Subject: [PATCH] Bug 1784179 - Don't stop at the first error during CI builds. r=firefox-build-system-reviewers,nalexander It can be a frustrating experience to push something to e.g. try, get build errors, fix them, and realize on a subsequent push that there were other build errors, but since the build failed as soon as it reached the first error, the logs didn't show them. While stopping at the first error locally is more helpful locally (although it still stop immediately and errors are often buried in the logs), it is actually desirable to avoid stopping on automation. Differential Revision: https://phabricator.services.mozilla.com/D154327 --- client.mk | 2 -- python/mozbuild/mozbuild/build_commands.py | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/client.mk b/client.mk index b0ace5d200b0..eb029435c671 100644 --- a/client.mk +++ b/client.mk @@ -61,9 +61,7 @@ endif ### Build it build:: +$(MOZ_MAKE) $(SCCACHE_STOP_ON_FAILURE) - ifdef MOZ_AUTOMATION -build:: +$(MOZ_MAKE) automation/build $(SCCACHE_STOP_ON_FAILURE) endif diff --git a/python/mozbuild/mozbuild/build_commands.py b/python/mozbuild/mozbuild/build_commands.py index fa3c7e334f8a..bd35a1660e5a 100644 --- a/python/mozbuild/mozbuild/build_commands.py +++ b/python/mozbuild/mozbuild/build_commands.py @@ -160,6 +160,9 @@ def build( doing_pgo = configure_args and "MOZ_PGO=1" in configure_args # Force verbosity on automation. verbose = verbose or bool(os.environ.get("MOZ_AUTOMATION", False)) + # Keep going by default on automation so that we exhaust as many errors as + # possible. + keep_going = keep_going or bool(os.environ.get("MOZ_AUTOMATION", False)) append_env = None # By setting the current process's priority, by default our child processes