Make nsXULElement::GetChildNodes use the same (live) node list that

nsGenericElement uses. Bug 240633, r+sr=jst on the C++ changes, r=neil, sr=jst on the JS changes.
2006-09-14 06:08:32 +00:00 · 2006-09-14 06:08:32 +00:00 · d55aee8d7a
--- a/suite/browser/sessionHistoryUI.js
+++ b/suite/browser/sessionHistoryUI.js
@ -304,7 +304,7 @@ function createRadioMenuItem( aParent, aIndex, aLabel, aChecked)
 function deleteHistoryItems(aParent)
  {
    var children = aParent.childNodes;
-    for (var i = 0; i < children.length; i++ )
+    for (var i = children.length - 1; i >= 0; --i )
      {
        var index = children[i].getAttribute( "index" );
        if (index)
--- a/suite/browser/urlbarBindings.xml
+++ b/suite/browser/urlbarBindings.xml
@ -191,9 +191,8 @@

      <method name="clearEngines">
        <body><![CDATA[
-          var kids = this.mSearchBox.childNodes;
-          for (var i = kids.length-1; i >= 0; --i)
-            this.mSearchBox.removeChild(kids[i]);
+          while (this.mSearchBox.hasChildNodes())
+            this.mSearchBox.removeChild(this.mSearchBox.lastChild);
        ]]></body>
      </method>