From d57114716b478a15d8dae3fae009dc6d870ab4b7 Mon Sep 17 00:00:00 2001 From: Patrick McManus Date: Fri, 18 Sep 2015 13:58:14 -0400 Subject: [PATCH] bug 366559 - patch 5, fix nsHTTPCompressConv manual addref r=bagder --- netwerk/streamconv/converters/nsHTTPCompressConv.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/netwerk/streamconv/converters/nsHTTPCompressConv.cpp b/netwerk/streamconv/converters/nsHTTPCompressConv.cpp index acc0bed37d68..a577ceb60618 100644 --- a/netwerk/streamconv/converters/nsHTTPCompressConv.cpp +++ b/netwerk/streamconv/converters/nsHTTPCompressConv.cpp @@ -496,17 +496,15 @@ nsresult NS_NewHTTPCompressConv(mozilla::net::nsHTTPCompressConv **aHTTPCompressConv) { NS_PRECONDITION(aHTTPCompressConv != nullptr, "null ptr"); - if (!aHTTPCompressConv) { return NS_ERROR_NULL_POINTER; } - *aHTTPCompressConv = new mozilla::net::nsHTTPCompressConv(); - - if (!*aHTTPCompressConv) { + nsRefPtr outVal = + new mozilla::net::nsHTTPCompressConv(); + if (!outVal) { return NS_ERROR_OUT_OF_MEMORY; } - - NS_ADDREF(*aHTTPCompressConv); + outVal.forget(aHTTPCompressConv); return NS_OK; }