Better fix for 49066. r=saari,danm

xpfe/global/resources/content/commonDialog.js

@@ -86,7 +86,7 @@ function commonDialogOnLoad()
     {
       case 2:
         var password2Container = document.getElementById("password2EditField");
-        password2Container.removeAttribute("hidden");
+        password2Container.removeAttribute("collapsed");
         var password2Field = document.getElementById("dialog.password2");
         password2Field.value = param.GetString(7);
         
@@ -159,13 +159,13 @@ function setCheckbox (aChkMsg, aChkValue)
 function unHideElementByID (aElementID)
 {
   var element = document.getElementById(aElementID);
-  element.removeAttribute("hidden");
+  element.removeAttribute("collapsed");
 }
 
 function hideElementById (aElementID)
 {
   var element = document.getElementById(aElementID)
-  element.setAttribute("hidden", "true");
+  element.setAttribute("collapsed", "true");
 }
 
 function onCheckboxClick(aCheckboxElement)

xpfe/global/resources/content/commonDialog.xul

@@ -26,15 +26,15 @@
       <box id="info.box" flex="1" orient="vertical" style="max-width: 45em;"/>
 
       <!-- edit fields -->
-      <box orient="vertical" id="loginEditField" hidden="true">
+      <box orient="vertical" id="loginEditField" collapsed="true">
         <text class="label" id="login.text" value="&editfield0.label;" for="dialog.loginname"/>
         <textfield tabindex="0" type="text" id="dialog.loginname" flex="1"/>
       </box>
-      <box orient="vertical" id ="password1EditField" hidden="true">
+      <box orient="vertical" id ="password1EditField" collapsed="true">
         <text class="label" id="password1.text" value="&editfield1.label;" for="dialog.password1"/>
         <textfield tabindex="1" type="password" id="dialog.password1" flex="1"/>
       </box>
-      <box orient="vertical" id="password2EditField" hidden="true">
+      <box orient="vertical" id="password2EditField" collapsed="true">
         <text class="label" id="password2.text" value="&editfield2.label;" for="dialog.password2"/>
         <textfield tabindex="1" type="password" id="dialog.password2" flex="1"/>
       </box>
@@ -42,7 +42,7 @@
       <spring flex="1"/>
       
       <!-- checkbox -->
-      <box id="checkboxContainer" hidden="true" autostretch="never">
+      <box id="checkboxContainer" collapsed="true" autostretch="never">
         <checkbox id="checkbox" oncommand="onCheckboxClick(this)" style="max-width: 40em;"/>
       </box>
     </box>