Bug 1726401 - Remove about_newtab_with_snippets perf test r=perftest-reviewers,AlexandruIonescu

Differential Revision: https://phabricator.services.mozilla.com/D123105
This commit is contained in:
Andrei Oprea 2021-08-23 15:15:10 +00:00
Родитель 15d95405d0
Коммит d68559b9bd
11 изменённых файлов: 3 добавлений и 178 удалений

Просмотреть файл

@ -168,7 +168,6 @@ _OPT\.OBJ/
^testing/talos/talos/tests/devtools/damp.manifest.develop
^testing/talos/talos/startup_test/startup_about_home_paint/startup_about_home_paint.manifest.develop
^testing/talos/talos/webextensions/
^testing/talos/talos/tests/about-newtab/about_newtab.manifest.develop
^talos-venv
^py3venv
^testing/talos/talos/mitmproxy/mitmdump

Просмотреть файл

@ -130,21 +130,6 @@ const MessageLoaderUtils = {
return provider.messages;
},
async _localJsonLoader(provider) {
let payload;
try {
payload = await (
await fetch(provider.location, {
credentials: "omit",
})
).json();
} catch (e) {
return [];
}
return payload.messages;
},
async _remoteLoaderCache(storage) {
let allCached;
try {
@ -417,8 +402,6 @@ const MessageLoaderUtils = {
return this._remoteLoader;
case "remote-settings":
return this._remoteSettingsLoader;
case "json":
return this._localJsonLoader;
case "remote-experiments":
return this._experimentsAPILoader;
case "local":

Просмотреть файл

@ -2728,25 +2728,6 @@ describe("ASRouter", () => {
group: "cfr",
});
});
it("should fetch json from url", async () => {
let result = await MessageLoaderUtils.loadMessagesForProvider({
location: "http://fake.com/endpoint",
type: "json",
});
assert.property(result, "messages");
assert.lengthOf(result.messages, FAKE_REMOTE_MESSAGES.length);
});
it("should catch errors", async () => {
fetchStub.throws();
let result = await MessageLoaderUtils.loadMessagesForProvider({
location: "http://fake.com/endpoint",
type: "json",
});
assert.property(result, "messages");
assert.lengthOf(result.messages, 0);
});
});
describe("#_remoteSettingsLoader", () => {
let provider;

Просмотреть файл

@ -58,7 +58,7 @@ figure out what suites and tests are available to run.
# Available suites:
# bcv (basic_compositor_video)
# chromez (about_preferences_basic:tresize:about_newtab_with_snippets)
# chromez (about_preferences_basic:tresize)
# dromaeojs (dromaeo_css:kraken)
# flex (tart_flex:ts_paint_flex)
# ...
@ -77,10 +77,6 @@ figure out what suites and tests are available to run.
# This test ensures basic a11y tables and permutations do not cause
# performance regressions.
#
# about_newtab_with_snippets
# --------------------------
# Load about ActivityStream (about:home and about:newtab) with snippets enabled
#
# ...
# Run the tests in "a11yr" listed above

Просмотреть файл

@ -58,7 +58,7 @@ figure out what suites and tests are available to run.
# Available suites:
# bcv (basic_compositor_video)
# chromez (about_preferences_basic:tresize:about_newtab_with_snippets)
# chromez (about_preferences_basic:tresize)
# dromaeojs (dromaeo_css:kraken)
# flex (tart_flex:ts_paint_flex)
# ...
@ -77,10 +77,6 @@ figure out what suites and tests are available to run.
# This test ensures basic a11y tables and permutations do not cause
# performance regressions.
#
# about_newtab_with_snippets
# --------------------------
# Load about ActivityStream (about:home and about:newtab) with snippets enabled
#
# ...
# Run the tests in "a11yr" listed above

Просмотреть файл

@ -4,7 +4,7 @@
"tests": ["basic_compositor_video"]
},
"chromez": {
"tests": ["about_preferences_basic", "tresize", "about_newtab_with_snippets"]
"tests": ["about_preferences_basic", "tresize"]
},
"dromaeojs": {
"tests": ["dromaeo_css", "kraken"]

Просмотреть файл

@ -1218,36 +1218,3 @@ class about_preferences_basic(PageloaderTest):
unit = "ms"
lower_is_better = True
fnbpaint = True
@register_test()
class about_newtab_with_snippets(PageloaderTest):
"""
Load about ActivityStream (about:home and about:newtab) with snippets enabled
"""
tpmanifest = "${talos}/tests/about-newtab/about_newtab.manifest"
tpcycles = 25
tppagecycles = 1
responsiveness = True
gecko_profile_interval = 1
gecko_profile_entries = 2000000
filters = filter.ignore_first.prepare(5) + filter.median.prepare()
unit = "ms"
lower_is_better = True
fnbpaint = True
preferences = {
# ensure that snippets are turned on and load the json messages
"browser.newtabpage.activity-stream.asrouter.providers.snippets": '{"id":"snippets","enabled":true,"type":"json","location":\
"http://fakedomain/tests/about-newtab/snippets.json",\
"updateCycleInMs":14400000}',
"browser.newtabpage.activity-stream.feeds.snippets": True,
"browser.newtabpage.activity-stream.feeds.system.topstories": True,
"browser.newtabpage.activity-stream.feeds.section.topstories": True,
"browser.newtabpage.activity-stream.feeds.section.topstories.options": '{"provider_name":""}', # NOQA: E501
"browser.newtabpage.activity-stream.discoverystream.endpoints": "http://fakedomain",
"browser.newtabpage.activity-stream.discoverystream.config": '{"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,\
"enabled":true,"show_spocs":false,"hardcoded_layout":false,"personalized":true,\
"layout_endpoint":\
"http://fakedomain/tests/about-newtab/ds_layout.json"}',
}

Просмотреть файл

@ -1,6 +0,0 @@
about:newtab
about:home
about:newtab
about:home
about:newtab
about:home

Просмотреть файл

@ -1,89 +0,0 @@
{
"spocs": {
"url": ""
},
"layout": [
{
"width": 12,
"components": [
{
"type": "TopSites",
"header": {
"title": "Top Sites"
},
"properties": null
},
{
"type": "Message",
"header": {
"title": "Recommended by Pocket",
"subtitle": "",
"link_text": "How it works",
"link_url": "https://getpocket.com/firefox/new_tab_learn_more",
"icon": "chrome://global/skin/icons/pocket.svg"
},
"properties": null,
"styles": {
".ds-message": "margin-bottom: -20px"
}
},
{
"type": "CardGrid",
"properties": {
"items": 3
},
"header": {
"title": ""
},
"feed": {
"embed_reference": null,
"url": "http://fakedomain/tests/about-newtab/topstories.json"
},
"spocs": {
"probability": 1,
"positions": [
{
"index": 2
}
]
}
},
{
"type": "Navigation",
"properties": {
"alignment": "left-align",
"links": [
{
"name": "Must Reads",
"url": "https://getpocket.com/explore/must-reads?src=fx_new_tab"
},
{
"name": "Productivity",
"url": "https://getpocket.com/explore/productivity?src=fx_new_tab"
},
{
"name": "Health",
"url": "https://getpocket.com/explore/health?src=fx_new_tab"
},
{
"name": "Finance",
"url": "https://getpocket.com/explore/finance?src=fx_new_tab"
},
{
"name": "Technology",
"url": "https://getpocket.com/explore/technology?src=fx_new_tab"
},
{
"name": "More Recommendations ",
"url": "https://getpocket.com/explore/trending?src=fx_new_tab"
}
]
}
}
]
}
],
"feeds": {},
"error": 0,
"status": 1
}

Различия файлов скрыты, потому что одна или несколько строк слишком длинны

Различия файлов скрыты, потому что одна или несколько строк слишком длинны