Bug 1729625 - [devtools] Remove beta label from Show Tabbing Order widget r=nchevobbe

Depends on D124804

Differential Revision: https://phabricator.services.mozilla.com/D124889

devtools/client/accessibility/components/DisplayTabbingOrder.js

@@ -21,7 +21,6 @@ const {
 class DisplayTabbingOrder extends PureComponent {
   static get propTypes() {
     return {
-      describedby: PropTypes.string,
       dispatch: PropTypes.func.isRequired,
       tabbingOrderDisplayed: PropTypes.bool.isRequired,
     };
@@ -46,7 +45,7 @@ class DisplayTabbingOrder extends PureComponent {
   }
 
   render() {
-    const { describedby, tabbingOrderDisplayed } = this.props;
+    const { tabbingOrderDisplayed } = this.props;
     return label(
       {
         className:
@@ -61,7 +60,6 @@ class DisplayTabbingOrder extends PureComponent {
         checked: tabbingOrderDisplayed,
         disabled: this.state.disabled,
         onChange: this.onChange,
-        "aria-describedby": describedby,
       }),
       L10N.getStr("accessibility.toolbar.displayTabbingOrder.label")
     );

devtools/client/accessibility/components/Toolbar.js

@@ -28,7 +28,6 @@ const DisplayTabbingOrder = createFactory(
 const { connect } = require("devtools/client/shared/vendor/react-redux");
 
 function Toolbar({ audit, simulate, supportsTabbingOrder, toolboxDoc }) {
-  const betaID = "beta";
   const optionalSimulationSection = simulate
     ? [
         div({
@@ -44,15 +43,7 @@ function Toolbar({ audit, simulate, supportsTabbingOrder, toolboxDoc }) {
           role: "separator",
           className: "devtools-separator",
         }),
-        span(
-          {
-            className: "beta",
-            role: "presentation",
-            id: betaID,
-          },
-          L10N.getStr("accessibility.beta")
-        ),
-        DisplayTabbingOrder({ describedby: betaID }),
+        DisplayTabbingOrder(),
       ]
     : [];
 

devtools/client/accessibility/test/node/components/__snapshots__/display-tabbing-order.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`DisplayTabbingOrder component: default render 1`] = `"<label class=\\"accessibility-tabbing-order devtools-checkbox-label devtools-ellipsis-text\\" for=\\"devtools-display-tabbing-order-checkbox\\" title=\\"Show tabbing order of elements and their tabbing index.\\"><input id=\\"devtools-display-tabbing-order-checkbox\\" class=\\"devtools-checkbox\\" type=\\"checkbox\\" aria-describedby=\\"test\\">Show Tabbing Order</label>"`;
+exports[`DisplayTabbingOrder component: default render 1`] = `"<label class=\\"accessibility-tabbing-order devtools-checkbox-label devtools-ellipsis-text\\" for=\\"devtools-display-tabbing-order-checkbox\\" title=\\"Show tabbing order of elements and their tabbing index.\\"><input id=\\"devtools-display-tabbing-order-checkbox\\" class=\\"devtools-checkbox\\" type=\\"checkbox\\">Show Tabbing Order</label>"`;
 
 exports[`DisplayTabbingOrder component: displaying tabbing order render/update 1`] = `"<label class=\\"accessibility-tabbing-order devtools-checkbox-label devtools-ellipsis-text\\" for=\\"devtools-display-tabbing-order-checkbox\\" title=\\"Show tabbing order of elements and their tabbing index.\\"><input id=\\"devtools-display-tabbing-order-checkbox\\" class=\\"devtools-checkbox\\" type=\\"checkbox\\">Show Tabbing Order</label>"`;
 

devtools/client/accessibility/test/node/components/display-tabbing-order.test.js

@@ -41,20 +41,14 @@ function testCheckbox(wrapper, expected) {
   const checkbox = label.childAt(0);
   expect(checkbox.prop("checked")).toBe(expected.checked);
   expect(checkbox.prop("disabled")).toBe(!!expected.disabled);
-  if (expected.describedby) {
-    expect(checkbox.prop("aria-describedby")).toBe(expected.describedby);
-  }
 }
 
 describe("DisplayTabbingOrder component:", () => {
   it("default render", () => {
-    const DESCRIBEDBY = "test";
     const store = setupStore();
-    const wrapper = mount(
-      Provider({ store }, DisplayTabbingOrder({ describedby: DESCRIBEDBY }))
-    );
+    const wrapper = mount(Provider({ store }, DisplayTabbingOrder()));
 
-    testCheckbox(wrapper, { checked: false, describedby: DESCRIBEDBY });
+    testCheckbox(wrapper, { checked: false });
   });
 
   it("toggle tabbing order overlay", () => {

devtools/client/locales/en-US/accessibility.properties

@@ -242,10 +242,6 @@ accessibility.progress.progressbar=Checking #1 node;Checking #1 nodes
 # accessibility panel overlay shown when accessibility audit is finishing up.
 accessibility.progress.finishing=Finishing up…
 
-# LOCALIZATION NOTE (accessibility.beta): A title text for the features in the
-# accessibility panel that are currently in beta.
-accessibility.beta=beta
-
 # LOCALIZATION NOTE (accessibility.pref.scroll.into.view.title): A title
 # text for the tooltip for the checkbox pref in the accessibility panel that
 # sets node auto scroll.