Bug 1516577 - Update GeckoView about:config visual design. r=geckoview-reviewers,snorp

Differential Revision: https://phabricator.services.mozilla.com/D59203

--HG--
extra : moz-landing-system : lando

mobile/android/chrome/geckoview/config.xhtml

@@ -47,7 +47,7 @@
                     <input class="pref-name" id="new-pref-name" type="text" placeholder="&newPref.namePlaceholder;"
                         onfocus="NewPrefDialog.focusName(event);"
                         oninput="NewPrefDialog.updateName(event);"/>
-                    <select class="pref-value" id="new-pref-type" onchange="NewPrefDialog.type = event.target.value;">
+                    <select id="new-pref-type" onchange="NewPrefDialog.type = event.target.value;">
                         <option value="boolean">&newPref.valueBoolean;</option>
                         <option value="string">&newPref.valueString;</option>
                         <option value="int">&newPref.valueInteger;</option>
@@ -59,7 +59,7 @@
                     <div class="pref-button toggle" onclick="NewPrefDialog.toggleBoolValue();">&newPref.toggleButton;</div>
                 </div>
 
-                <div class="pref-item-line">
+                <div class="pref-item-line" id="new-pref-line-input">
                     <input class="pref-value" id="new-pref-value-string" placeholder="&newPref.stringPlaceholder;"/>
                     <input class="pref-value" id="new-pref-value-int" placeholder="&newPref.numberPlaceholder;" type="number"/>
                 </div>
@@ -75,7 +75,7 @@
 
         <ul id="prefs-container"/>
 
-        <ul id="loading-container"><li></li></ul>
+        <div id="loading-container"></div>
 
     </div>
 

mobile/android/themes/geckoview/config.css

@@ -2,14 +2,43 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
+:root {
+    --background-color: #fff;
+    --text-color: #0c0c0d;
+    --border-color: #e1e1e2;
+
+    --toolbar-background-color: #f9f9fa;
+    --searchbar-background-color: #ededf0;
+    --searchbar-focused-background-color: #fff;
+
+    --deemphasized-border-color: rgba(0,0,0,0.05);
+    --deemphasized-text-color: rgba(0,0,0,0.5);
+}
+
+@media (prefers-color-scheme: dark) {
+    :root {
+        --background-color: #292833;
+        --text-color: #f9f9fa;
+        --border-color: rgba(255,255,255,0.15);
+
+        --toolbar-background-color: #1c1b22;
+        --searchbar-background-color: #3f3e46;
+        --searchbar-focused-background-color: #4c4a54;
+
+        --deemphasized-border-color: rgba(249,249,250,0.05);
+        --deemphasized-text-color: rgba(249,249,250,0.5);
+    }
+}
+
 html,
 body {
     margin: 0;
     padding: 0;
-    background-color: #ced7de;
     -moz-user-select: none;
     font-family: sans-serif;
     -moz-text-size-adjust: none;
+    background-color: var(--background-color);
+    color: var(--text-color);
 }
 
 .toolbar {
@@ -20,96 +49,84 @@ body {
     top: 0;
     left: 0;
     z-index: 10;
-    box-shadow: 0 0 3px #444;
-    background-color: #ced7de;
-    color: #000000;
+    background-color: var(--toolbar-background-color);
     font-weight: bold;
-    border-bottom: 2px solid #f27900;
+    box-shadow: 0 2px 7px rgba(0,0,0,0.25);
 }
 
 .toolbar-container {
     max-width: 40em;
-    margin-left: auto;
-    margin-right: auto;
+    margin-inline: auto;
 }
 
 #filter-container {
     margin: 0.375em;
     height: 2em;
+    background-color: var(--searchbar-background-color);
+    border-radius: 0.25em;
     border: 1px solid transparent;
-    border-image-source: url("chrome://geckoview/skin/images/textfield.png");
-    border-image-slice: 1 1 3 1;
-    border-image-width: 1px 1px 3px 1px;
     overflow: hidden;
     display: flex;
-    flex-direction: row;
-    float: right;
+    float: inline-end;
 }
 
-#filter-container:dir(rtl) {
-    float: left;
+#filter-container:focus-within {
+    background-color: var(--searchbar-focused-background-color);
+    box-shadow: 0 1px 6px rgba(0,0,0,.1);
 }
 
 #filter-input {
-    -moz-appearance: none;
     border: none;
-    background-image: none;
-    background-color: transparent;
-    display: inline-block;
-    width: 12em;
-    min-width: 0;
-    color: #000000;
-    opacity: 1;
-    flex: 1 1 auto;
-}
-
-#filter-input::placeholder {
-    color: #777777;
-}
-
-.toolbar input {
-    display: inline-block;
+    background: none;
+    color: inherit;
+    flex-grow: 1;
     height: 100%;
-    min-width: 3em;
     box-sizing: border-box;
     opacity: 0.75;
 }
 
 #new-pref-toggle-button {
-    background-position: center center;
-    background-image: url("chrome://geckoview/skin/images/config-plus.png");
-    background-size: 3em 3em;
+    background-image: url("chrome://geckoview/skin/images/add.svg");
+    background-size: 1.25em;
+    background-position: center;
+    background-repeat: no-repeat;
     height: 3em;
     width: 3em;
-    display: inline-block;
-    outline-style: none;
-    float: left;
+    outline: none;
+    float: inline-start;
+    -moz-context-properties: fill, fill-opacity;
+    fill: currentColor;
+    fill-opacity: 0.8;
 }
 
-#new-pref-toggle-button:dir(rtl) {
-    float: right;
+#filter-search-button,
+#filter-input-clear-button {
+    background-size: 1em;
+    background-position: center;
+    background-repeat: no-repeat;
+    height: 2em;
+    width: 2em;
+    outline: none;
+    display: inline-block;
+    -moz-context-properties: fill, fill-opacity;
+    fill: currentColor;
+    fill-opacity: 0.8;
 }
 
 #filter-search-button {
-    background-image: url("chrome://geckoview/skin/images/search.png");
-    background-size: 2em 2em;
-    height: 2em;
-    width: 2em;
-    display: inline-block;
-    outline-style: none;
+    background-image: url("chrome://geckoview/skin/images/search.svg");
+}
+
+#filter-search-button:dir(rtl) {
+    scale: -1 1;
 }
 
 #filter-input-clear-button {
-    background-image: url("chrome://geckoview/skin/images/search-clear-30.png");
-    background-size: 2em 2em;
-    height: 2em;
-    width: 2em;
-    display: inline-block;
-    outline-style: none;
+    background-image: url("chrome://geckoview/skin/images/search-clear.svg");
 }
 
-#filter-input[value=""] + #filter-input-clear-button {
-    display: none;
+#filter-input:placeholder-shown + #filter-input-clear-button {
+    visibility: hidden; /* display: none; causes the input size to change */
 }
 
 .toolbar-item {
@@ -121,34 +138,33 @@ body {
 
 #content {
     position: relative;
-    margin: 0;
-    margin-left: auto;
-    margin-right: auto;
-    padding-left: 0;
-    padding-right: 0;
+    margin: 0 auto;
+    padding-inline: 0;
     min-height: 100%;
     max-width: 40em;
 }
 
-ul {
-    list-style-position: inside;
-    border: 1px solid #808080;
-    background-color: #ffffff;
+#prefs-container {
+    list-style: none;
     min-height: 100%;
     width: 100%;
     margin: 0;
     padding: 0;
     box-sizing: border-box;
-    box-shadow: 0 0 5px #000000;
     overflow-x: hidden;
 }
 
+#prefs-container li {
+    border-bottom: 1px solid var(--border-color);
+    cursor: pointer;
+}
+
 #new-pref-container {
     width: 100%;
     margin: 0;
-    background-color: #ffffff;
+    background-color: var(--background-color);
+    box-shadow: 0 5px 18px rgba(0,0,0,.2);
     box-sizing: border-box;
-    box-shadow: 0 0 5px #000000;
     overflow-x: hidden;
     max-width: 40em;
     max-height: 100%;
@@ -162,21 +178,13 @@ ul {
 #new-pref-container input,
 #new-pref-container select {
     border: none;
-    background-image: none;
+    background: none;
 }
 
 #new-pref-container.show {
     display: block;
 }
 
-li {
-    list-style-type: none;
-    border-bottom: 1px solid #d3d3d3;
-    opacity: 1;
-    background-color: #ffffff;
-    cursor: pointer;
-}
-
 #new-pref-line-boolean,
 #new-pref-value-string,
 #new-pref-value-int {
@@ -185,35 +193,47 @@ li {
 #new-pref-item[typestyle="boolean"] #new-pref-line-boolean,
 #new-pref-item[typestyle="string"] #new-pref-value-string,
 #new-pref-item[typestyle="int"] #new-pref-value-int {
-    display: block;
+    display: flex;
+}
+#new-pref-item[typestyle="boolean"] #new-pref-line-input {
+    border-top: none;
 }
 
 .pref-name,
 .pref-value {
     padding: 15px 10px;
-    text-align: left;
+    text-align: match-parent;
     text-overflow: ellipsis;
     overflow: hidden;
-    background-image: none;
+    background: none;
+    color: inherit;
     direction: ltr;
 }
 
 .pref-value {
-    color: rgba(0,0,0,0.5);
     flex: 1 1 auto;
     border: none;
-    -moz-appearance: none;
-    background-image: none;
-    background-color: transparent;
     unicode-bidi: plaintext;
 }
 
 .pref-name[locked] {
-    padding-right: 20px;
-    background-image: url("chrome://geckoview/skin/images/lock.png");
+    -moz-context-properties: fill, fill-opacity;
+    fill: currentColor;
+    fill-opacity: 0.8;
+    background-image: url("chrome://geckoview/skin/images/lock.svg");
     background-repeat: no-repeat;
-    background-position: right 50%;
-    background-size: auto 60%;
+    background-position-y: center;
+    background-size: 1em;
+}
+
+:dir(ltr) > .pref-name[locked] {
+    background-position-x: right 10px;
+    padding-right: 30px;
+}
+
+:dir(rtl) > .pref-name[locked] {
+    background-position-x: 10px;
+    padding-left: 30px;
 }
 
 #new-pref-name {
@@ -221,17 +241,18 @@ li {
 }
 
 #new-pref-type {
-    display: inline-block !important;
-    border-left: 1px solid #d3d3d3;
-    width: 10em;
-    text-align: right;
+    -moz-appearance: none;
+    color: inherit;
+    border-inline-start: 1px solid var(--deemphasized-border-color) !important;
+    text-align: center;
+    width: 9em;
+    padding-inline: 8px;
 }
 
 .pref-item-line {
-    border-top: 1px solid rgba(0,0,0,0.05);
-    color: rgba(0,0,0,0.5);
+    border-top: 1px solid var(--deemphasized-border-color);
+    color: var(--deemphasized-text-color);
     display: flex;
-    flex-direction: row;
 }
 
 #new-pref-value-boolean {
@@ -239,7 +260,7 @@ li {
 }
 
 #new-pref-container .pref-button.toggle {
-    display: inline-block;
+    display: flex;
     opacity: 1;
     flex: 0 1 auto;
     float: right;
@@ -263,11 +284,11 @@ li {
 }
 
 #new-pref-container .pref-button.create[disabled] {
-    color: #d3d3d3;
+    opacity: 0.5;
 }
 
 .pref-item.selected {
-    background-color: rgba(0,0,255,0.05);
+    background-color: hsla(0,0%,60%,.2);
 }
 
 .pref-button {
@@ -276,7 +297,7 @@ li {
     align-items: center;
     text-align: center;
     padding: 10px 1em;
-    border-left: 1px solid rgba(0,0,0,0.1);
+    border-inline-start: 1px solid var(--deemphasized-border-color);
     opacity: 0;
     transition-property: opacity;
     transition-duration: 500ms;
@@ -294,32 +315,37 @@ li {
     opacity: 1;
 }
 
-.pref-button:active {
-    background-color: rgba(0,0,255,0.2);
+.pref-button:active,
+#new-pref-type:active {
+    background-color: hsla(0,0%,60%,.4);
 }
 
 .pref-button[disabled] {
     display: none;
 }
 
-.pref-button.up {
-    background-image: url("chrome://geckoview/skin/images/arrowup-16.png");
-    background-size: 1em 1em;
-    background-position: center center;
+.pref-button.up,
+.pref-button.down {
+    -moz-context-properties: fill, fill-opacity;
+    fill: var(--text-color);
+    fill-opacity: 0.8;
+    background-size: 1em;
+    background-position: center;
     background-repeat: no-repeat;
 }
 
+.pref-button.up {
+    background-image: url("chrome://geckoview/skin/images/arrow-up.svg");
+}
+
 .pref-button.down {
-    background-image: url("chrome://geckoview/skin/images/arrowdown-16.png");
-    background-size: 1em 1em;
-    background-position: center center;
-    background-repeat: no-repeat;
+    background-image: url("chrome://geckoview/skin/images/arrow-down.svg");
 }
 
 #prefs-shield {
     width: 100%;
     height: 100%;
-    background-color: rgba(0,0,0,0.5);
+    background-color: rgba(0,0,0,0.45);
     position: fixed;
     top: 0;
     left: 0;
@@ -334,11 +360,20 @@ li {
     opacity: 1;
 }
 
-#loading-container > li {
-    background-image: url(chrome://geckoview/skin/images/throbber.png);
-    background-position: center center;
-    background-repeat: no-repeat;
-    padding-left: 40px;
-    height: 3em;
-    width: 100%;
+#loading-container::before {
+    content: "";
+    display: block;
+    width: 1.25em;
+    height: 1.25em;
+    border: 0.15em solid currentColor;
+    margin: 1em auto;
+    border-right-color: transparent;
+    border-radius: 100%;
+    opacity: 0.8;
+    animation: 1.1s linear infinite spin;
+}
+
+@keyframes spin {
+    from { transform: none; }
+    to { transform: rotate(360deg); }
 }

mobile/android/themes/geckoview/images/add.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
+  <path d="M14 7H9V2a1 1 0 0 0-2 0v5H2a1 1 0 1 0 0 2h5v5a1 1 0 0 0 2 0V9h5a1 1 0 0 0 0-2z"/>
+</svg>

mobile/android/themes/geckoview/images/arrow-down.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
+  <path d="M8 12a1 1 0 0 1-.707-.293l-5-5a1 1 0 0 1 1.414-1.414L8 9.586l4.293-4.293a1 1 0 0 1 1.414 1.414l-5 5A1 1 0 0 1 8 12z"/>
+</svg>

mobile/android/themes/geckoview/images/arrow-up.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
+  <path d="M8 4a1 1 0 00-.707.293l-5 5a1 1 0 001.414 1.414L8 6.414l4.293 4.293a1 1 0 001.414-1.414l-5-5A1 1 0 008 4z"/>
+</svg>

mobile/android/themes/geckoview/images/dropmarker-right.svg

@@ -1,4 +1,3 @@
-<?xml version="1.0"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

mobile/android/themes/geckoview/images/dropmarker.svg

@@ -1,4 +1,3 @@
-<?xml version="1.0"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

mobile/android/themes/geckoview/images/lock.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
+  <path d="M12,7 L13,7 C13.5522847,7 14,7.44771525 14,8 L14,14 C14,14.5522847 13.5522847,15 13,15 L3,15 C2.44771525,15 2,14.5522847 2,14 L2,8 C2,7.44771525 2.44771525,7 3,7 L4,7 L4,5.00032973 C4,2.79202307 5.79321704,1 8,1 C10.2075938,1 12,2.79481161 12,5.00032973 L12,7 Z M10,7 L10,5.00032973 C10,3.89878113 9.10242341,3 8,3 C6.89748845,3 6,3.89689088 6,5.00032973 L6,7 L10,7 Z"/>
+</svg>

mobile/android/themes/geckoview/images/search-clear.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
+  <path d="M6.586 8l-2.293 2.293a1 1 0 0 0 1.414 1.414L8 9.414l2.293 2.293a1 1 0 0 0 1.414-1.414L9.414 8l2.293-2.293a1 1 0 1 0-1.414-1.414L8 6.586 5.707 4.293a1 1 0 0 0-1.414 1.414L6.586 8zM8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0z"/>
+</svg>

mobile/android/themes/geckoview/images/search.svg

@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="context-fill" fill-opacity="context-fill-opacity">
+   <path d="M15.707 14.293l-4.822-4.822a6.019 6.019 0 1 0-1.414 1.414l4.822 4.822a1 1 0 0 0 1.414-1.414zM6 10a4 4 0 1 1 4-4 4 4 0 0 1-4 4z"/>
+</svg>

mobile/android/themes/geckoview/jar.mn

@@ -18,13 +18,11 @@ geckoview.jar:
   skin/images/accessiblecaret-tilt-right-hdpi.png   (images/accessiblecaret-tilt-right-hdpi.png)
   skin/images/accessiblecaret-tilt-right-xhdpi.png  (images/accessiblecaret-tilt-right-xhdpi.png)
   skin/images/accessiblecaret-tilt-right-xxhdpi.png (images/accessiblecaret-tilt-right-xxhdpi.png)
-  skin/images/arrowdown-16.png              (images/arrowdown-16.png)
-  skin/images/arrowup-16.png                (images/arrowup-16.png)
-  skin/images/config-plus.png               (images/config-plus.png)
+  skin/images/add.svg                       (images/add.svg)
+  skin/images/arrow-down.svg                (images/arrow-down.svg)
+  skin/images/arrow-up.svg                  (images/arrow-up.svg)
   skin/images/dropmarker-right.svg          (images/dropmarker-right.svg)
   skin/images/dropmarker.svg                (images/dropmarker.svg)
-  skin/images/lock.png                      (images/lock.png)
-  skin/images/search-clear-30.png           (images/search-clear-30.png)
-  skin/images/search.png                    (images/search.png)
-  skin/images/textfield.png                 (images/textfield.png)
-  skin/images/throbber.png                  (images/throbber.png)
+  skin/images/lock.svg                      (images/lock.svg)
+  skin/images/search-clear.svg              (images/search-clear.svg)
+  skin/images/search.svg                    (images/search.svg)