Bug 1528651 - Fix warnings and re-enable warnings-as-errors in ipc/mscom/. r=aklotz

ipc/mscom/InterceptorLog.cpp

@@ -435,7 +435,7 @@ void Logger::Flush() {
     uint32_t bytesWritten;
     nsCString& line = linesToWrite[i];
     nsresult rv = mLogFile->Write(line.get(), line.Length(), &bytesWritten);
-    NS_WARN_IF(NS_FAILED(rv));
+    Unused << NS_WARN_IF(NS_FAILED(rv));
   }
 }
 

ipc/mscom/Registration.cpp

@@ -415,7 +415,7 @@ static CRITICAL_SECTION* GetMutex() {
 #endif
   }
 
-  sRegistry->emplaceBack(aProxy);
+  MOZ_ALWAYS_TRUE(sRegistry->emplaceBack(aProxy));
 }
 
 /* static */ void RegisteredProxy::DeleteFromRegistry(RegisteredProxy* aProxy) {
@@ -449,7 +449,7 @@ void RegisterArrayData(const ArrayData* aArrayData, size_t aLength) {
     ClearOnShutdown(&sArrayData, ShutdownPhase::ShutdownThreads);
   }
 
-  sArrayData->emplaceBack(MakePair(aArrayData, aLength));
+  MOZ_ALWAYS_TRUE(sArrayData->emplaceBack(MakePair(aArrayData, aLength)));
 }
 
 const ArrayData* FindArrayData(REFIID aIid, ULONG aMethodIndex) {

ipc/mscom/SpinEvent.cpp

@@ -28,7 +28,7 @@ bool SpinEvent::sIsMulticore = false;
 
 SpinEvent::SpinEvent() : mDone(false) {
   static const bool gotStatics = InitStatics();
-  MOZ_ASSERT(gotStatics);
+  MOZ_ALWAYS_TRUE(gotStatics);
 
   mDoneEvent.own(::CreateEventW(nullptr, FALSE, FALSE, nullptr));
   MOZ_ASSERT(mDoneEvent);

ipc/mscom/moz.build

@@ -88,6 +88,3 @@ FINAL_LIBRARY = 'xul'
 
 with Files("**"):
     BUG_COMPONENT = ("Core", "IPC: MSCOM")
-
-if CONFIG['CC_TYPE'] == 'clang-cl':
-    AllowCompilerWarnings()  # workaround for bug 1090497

ipc/mscom/oop/moz.build

@@ -37,6 +37,3 @@ FORCE_STATIC_LIB = True
 # This DLL may be loaded into other processes, so we need static libs for
 # Windows 7 and Windows 8.
 USE_STATIC_LIBS = True
-
-if CONFIG['CC_TYPE'] == 'clang-cl':
-    AllowCompilerWarnings()  # workaround for bug 1090497